Openrct2: Deleting the sign after copy/pasting it will crash the game

[xp4xbox]

OS: Windows 7
Version: 0.0.7
Build: f6f6d27

If you open up a park then build a sign and then copy and paste it onto another tile. Deleting either copied one or original one will cause the game to crash. It will still crash even if you dont use the tile inspector to delete the sign.

• [N/A ] Reproducible in RCT2 (vanilla)?
• [ both] Multiplayer?

Steps to reproduce:

1. Open up any park
2. Build any sign on any path.
3. Open up tile inspector and click on the signs
4. Click Copy
5. Click Paste on any other tile
6. Delete either one of the signs, and the game will crash.

[Sweet-Tan]

.dmp and .sv6 regarding this issue
ec8846b3-cbae-4fb1-9d58-3b4f9c776051.zip

[Gymnasiast]

@Broxzier Could you look into this?

[IntelOrca]

Its possible that this is caused by the banners sharing the same string ID. If a banner is copied, it needs to duplicate and use a new user string.

[duncanspumpkin]

Does it also duplicate the banner ID?

[Broxzier]

@duncanspumpkin The pasted element is an exact copy, no new string or banner ID will be assigned when placing one, nor will they be destroyed when removing them using the Tile Inspector.

[duncanspumpkin]

In some ways it's nice to keep the link and just modify the destruct to prevent the ID from being freed.

[Gymnasiast]

I think it would be better to just copy everything, that's what the user expects from copy-paste anyway.

[IntelOrca]

Yes there are too many side effects with sharing entities. If you select no entry on one banner, you don't want the copy to also be no entry. And the same for the text as well. We have already had previous bugs where changing the string of one thing changes the string of something else that is unrelated.

[Broxzier]

It does not crash anymore, but the moment one gets deleted, all copies will disappear, and the moment you build a new one, they reappear with the style of the new banner. Shall we leave it as is, create new strings/banners when pasting, or make the delete function smarter (e.g. by checking if any map elements refer to the banner index)?

[IntelOrca]

It should copy the element and give it a new string ID.

[xp4xbox]

Extremely arbitrary, no longer crashes. Should I close this?

[Gymnasiast]

No. The behaviour is still not correct.
Also, bugs are rarely 'arbitrary'. Feature requests can be, but not bugs.