Openrct2: leading / trailing whitespace in player name should removed

[YJSoft]

OS: Windows 10
Version: 0.0.5
Commit/Build: ae05e0f

Player name can't be duplicated in normal ways if player is registed to server(it will became Player #2) but this can be bypassed by adding space to end of player's name. this can be confusing since there's no way to distinguish "Player" and "Player ".

trailing whitespace should removed by client and server so there won't be any confusion.

• [ ] Reproducible in RCT2 (vanilla)?
• [x] Multiplayer?

[marijnvdwerf]

What about leading whitespace? Or the different variants of spaces?

[Ryder17z]

Only visible characters should be allowed.

[Dracheron]

Honestly, this could be fixed by adding character codes so that there can be no confusion in the future to a player's username

[marijnvdwerf]

And then there's IJ (IJ) vsIJ (IJ) (though cases like these are less of an issue when the sprite font is used)

[janisozaur]

Let's say we trim the whitespace. Where do we that? In client username selection? What if the key user has registered with his server of choice was that of a username with space? Should servers validate and enforce this? Since we expect clients to trim usernames, a hacked client allowing untrimmed usernames would be a dead giveaway of it being up to no good. Or should we just rename the user to a one with trimmed whitespace?

[IntelOrca]

I think servers use what ever user name is in the users.json, so you should be able to just trim it on the server on first adding a new user.

[Chaosmeister]

How should usernames that consist only of whitespaces be handled?
They could be replaced with _ or something more visible like #
Applying this to only to leading and trailing whitespaces still leaves possible attacks aimed at usernames with allowed whitespaces:
Allowed_Name - Allowed__Name (markdown trims multiple whitespaces).

5015 would help in this case.

[Dracheron]

simple, if it's all whitespaces, it's invalid... (imagine trying to click
on to copy and paste or guess the length of the name should it be all
whitespaces)

On Sat, Jun 24, 2017 at 5:51 PM, Tomas Dittmann [e-mail]
wrote:

How should usernames that consist only of whitespaces be handled?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/OpenRCT2/OpenRCT2/issues/4301#issuecomment-310868004,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AML0tAYINHWkJ-VSc7ofWCdtOBO-_tjcks5sHYTmgaJpZM4JmZ7h
.