Openra: LAN discovery

[RobotCaleb]

I noticed there is no LAN discovery support. LAN parties might enjoy it more if the games could be found.

https://www.reddit.com/r/openra/comments/3ducd2/want_to_play_locally_with_my_father/ct8slv9

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[Mailaender]

@markolson added it in his private https://github.com/markolson/OpenRA/tree/lan The thirdparty dependency is available via https://www.nuget.org/packages/Lidgren.Network/

[markolson]

Blast from the past. I'm happy to take another look at OpenRA and get that branch caught up if it's something that could be valuable to merge in.

[Phrohdoh]

@markolson It is often requested, please do. :)

[hoxworth]

:+1: @markolson Add all the things.

[spacemunkay]

:+1: go @markolson!

[llimllib]

:performing_arts: @markolson contribute for the good of humanity

[Micr0Bit]

:+1: @markolson

[xan2622]

@markolson

[ghost]

:+1:

[rob-v]

I found 'simple' working library so I could implement LAN discovery. I integrated LAN games with other games, this could be adjusted.

[hoxworth]

As long as @markolson is involved I'm happy

[rob-v]

I am not sure above the reactions above.. Is this something I could finish using this library https://github.com/rix0rrr/beacon ?

[pchote]

@rob-v if you think you have a solid solution for this, then please do file a PR!

I also don't understand what happened in the comment above...

[markolson]

I initially made a LAN patch for local play at work, and that's just some old coworkers and I being dumb. If you want to work on this, by all means please do - I tried to get something working again a while back and couldn't.

[chrisforbes]

@rob-v Looking forward to your pull request.

[rob-v]

Thanks all. Assuming the used library rix0rrr/beacon, which works fine in my tests, is solid. Thanks to its simple interface, also my integration with other MP games is simple, so I hope after a review and update of the integration it will be good solution.
In case of major design concern with used rix0rrr/beacon, I could either try to use Lidgren.Network library used by @markolson or check his branch if it could be finished if he doesn't prefer to finish it by himself, otherwise you can close the PR #13132 to let it implement by someone with more network dev experience.
In current implementation you see only Waiting LAN games, not Started.