Openra: Source tarballs and zips don't have the correct version set

Created on 5 Mar 2017  路  9Comments  路  Source: OpenRA/OpenRA

The binary versions for releases have correct versions in the game. But if you compile from source, for example, for latest playtest, it will say "{DEV_VERSION}" instead of "playtest-20170304".

Packaging

Most helpful comment

Since we have moved to a (prep-) branched model and dont care about maintaining linear history i think we could consider implementing a local / automated command that sets the version and then tags that commit.

All 9 comments

Your PR is really shitty.

@Snurre86: If you don't have something constructive to add, don't post anything at all. And if you post something like this again, I will block you from OpenRA.

@dtluna: the source tarball and zip are created automatically by Github from the repository contents, we don't create them ourselves. And since the files in the repository contain the placeholder, they end up in the archives as well.

I think the proper solution here is to add instructions how to set the version without git installed to the Compiling page

@obrakmann thank you very much.

Since we have moved to a (prep-) branched model and dont care about maintaining linear history i think we could consider implementing a local / automated command that sets the version and then tags that commit.

I like @pchote's suggestion.

It would be simpler if we just create a versioned source tarball (maybe tar.bz2) during release compilation that includes all thirdparty libraries, the changelog and a GeoIP database so it builds without any further downloads. :battery: included so to speak.

Dependency fetching is platform specific (macOS binaries, Windows binaries, linux lua config), so can't be done up front.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

MlemandPurrs picture MlemandPurrs  路  4Comments

TheMightyAltroll picture TheMightyAltroll  路  3Comments

drunsinn picture drunsinn  路  4Comments

AliT1993 picture AliT1993  路  3Comments

ghost picture ghost  路  4Comments