Openra: [D2K] Show unlocked things in tooltips

[tytannial]

The upgrade tooltips are too simple. It should show unlocked things.

[ltem]

Hi,

I would like to do the PR for this issue. It is already working on my side but such topics are prone to style/text changes.

Upgrade Conyard:

Upgrade Barrack:

Upgrade Light Factory:

Upgrade Heavy Factory:
Maybe this should be split on two lines.

Upgrade Research Center:

Would this be possible? I'm new to git but if I follow the OpenRA wiki I think it should work :)

[MustaphaTR]

Well, it looks fine but

1-) You miswrote Atreides. There is no s after A.
2-) Use full and current names of units, Large Concrete, Thumper Infantry, Missile Quad and IX Research Center,
3-) Put Trooper before Engineer.

[ltem]

1-) Removed the awkward s

2-) Concrete: Large concrete inherits from ^concrete and doesn't have its own tooltip, so ingame both concrete slabs are called "Concrete" LinkToLine
I added the Tooltips (Concrete Slab and Large Concrete Slab) in the structure yaml

Thumper: There is no Thumper Infantry in the infantry.yaml just Thumper... so I kept it this way

3-) Done

So can I PR it?

[MustaphaTR]

Hmm, i didn't check the OpenRA's unit names. Thumper is called Thumper Infantry in otiginal game. Normal Concrete is called just Concrete, so "Large Concrete" is better imo. Actually forget it, it is better with "Slab" even tho it is not like that in original game.

Looks like there are other inconsistent with original names. I think it would be good it you fix them too when you are in it.

• Thumper --> Thumper Infantry
• IX Lab --> IX Research Center

Some other units/ buildings has extra words in it (Raider Trike, Missile Quad, Spice Rafinery etc.) when compared to original but i guess it is fine so don't touch them.

I think you can file a PR after that.

[pchote]

These tooltips are unreasonably wide, so you should add linebreaks.

[ltem]

@MustaphaTR: Yeah the naming is generally a bit inconsistent (IX Research Centre (UK form: manual and in OpenRA yaml) <> IX Research Center (US form: gruntmodversion and online-wiki)
I have chosen the UK version because it is like this in the yaml-file...

@pchote: less wide version

[chrisforbes]

Default language should be consistently US English.

[ltem]

Okay, I can do these renames but I don't know if there are any additional changes needed.

The repository search listed me these files: Link

• 4 yaml files
• 1 C# file

[MustaphaTR]

There shouldn't be any additional changes needed, except maps that may have IX Research Center placed, which is a thing map makers need to do, not you. None of the maps comes with OpenRA D2K mod have such as only Atr1-3 is made yet.

But there is another thing, i can't check right now as my this computer doesn't run TibEd, but if original codename was research_centre, i think we should keep it. If this is true just change the visible name (i.e. Tooltip:) and not codename.

[ltem]

Okay, I will only change the Tooltip

[reaperrr]

Closed via #12547.