Openlibrary: Markdown help button does not do anything

Created on 12 Nov 2019  路  13Comments  路  Source: internetarchive/openlibrary

Help button doesn't do anything

Evidence / Screenshot (if possible)

image

Relevant url?

e.g. https://openlibrary.org/books/OL25934687M/P.S._I_Still_Love_You/edit

Expectation

It should serve some purpose

Details

  • Logged in (Y/N)? Y
  • Browser type/version? FF69
  • Operating system? Win10

Proposal & Constraints

Stakeholders

UI Good First Issue Triage 3 Editing Bug

All 13 comments

If it doesn't do anything, we should investigate whether it once did something (i.e. is this a regression?). Once this is done, we should document our findings here and make a decision between fixing the regression or removing the element.

Since there's a contained element:

<a href="/help/markdown" target="_new" title="Formatting Help"></a>

I'm guessing that's what it's supposed to do.

The options bar for this markdown editor is initialized in jquery.wmd.js line 1574. It also looks like the button is treated differently when run through function setupButton(button, isEnabled) on line 1468.

After this initialization this leaves the help button with no function assigned to the onclick event, and a massless (unclickable) tag as a child.

... I think.

Also, the href does take us to a markdown help page.

Hey @mekarpeles @tfmorris can i work on this issue.

@JordanDysart Sounds like you did some investigation. Are you preparing a fix or should @aashimgarg work on it?

Hey @tfmorris, I hadn't heard anything back (_I also didn't follow up_), about how we would fix this. From what I found in the forked markdown editor code, is the child tag is not given a width or height so you can't click it. This button looks like it was always planned to open up the md help page, but it was just never tested.

I haven't put anything together to fix it, so @aashimgarg feel free to work on the issue.

hello everyone , my self Abhishek mishra , i want to work on this issue . so can i work on this issue.

@Abhishek856 ya sure go ahead

Hey @JordanDysart @tfmorris
This issue is still open and no one has looked into it!
Can I work on this issue?

Hey @mightysood, I would suggest putting your fix together and just submitting it. It's going to be a good experience regardless. I'm not currently working on it.

Hi @JordanDysart @tfmorris
I have root caused this issue. There is a library called wmd used with