Openlibrary: Remove Broken "List" feature on Publishers Pages

Created on 5 Feb 2019  路  7Comments  路  Source: internetarchive/openlibrary

Visit https://openlibrary.org/publishers/Barnes_&_Noble
Click "Create a new list"

Nothing happens.

Try to add to an existing list and see:

Request URL: https://openlibrary.org/people/jdlrobson/lists/OL131254L/seeds.json
Request Method: POST
Status Code: 500 Internal Server Error

Seems like this is a problem with the API.
(We've noted the error 2019-02-05/012800436803 and will look into it as soon as possible. Head for home?)

Server UI Good First Issue @mekarpeles 3 Lists Bug

Most helpful comment

Proposing we remove the "Add to List" component from Publisher pages and mark as a first good issue.

Any disagreements?

All 7 comments

I reproduced this today. It is specifically a problem on the publisher page. Is adding a publisher to a list even supposed to be possible? @mekarpeles, what do you think the priority of this should be?

+1 can reproduce

Proposing we remove the "Add to List" component from Publisher pages and mark as a first good issue.

Any disagreements?

From what I understand, I have to remove
#: widget.html:193 msgid "Add to List" msgstr "" from messages.pot and the corresponding div from widget.html right?

In that case, I would like to claim this issue

Yup after doing that we will also need to review the css of the page too and likely remove the feature's CSS from the subject page.

Ok, I'll work on this @mekarpeles

Edit: Do I need to wait for a go-ahead? Or can I just make the PR?

@mekarpeles: Does #3197 seem like a good fit for the issue or the problem still persists?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

dcapillae picture dcapillae  路  4Comments

jdlrobson picture jdlrobson  路  5Comments

BrittanyBunk picture BrittanyBunk  路  4Comments

bitnapper picture bitnapper  路  4Comments

Yashs911 picture Yashs911  路  5Comments