Openlibrary: git submodules not working while cloning with https rather than git ssh

[ayushnawal]

Description

While using URL of https while cloning the OL github . The setup gets disturbed at step no. 17 while building the first image . although images built succesfully but on running docker-compose up , terminal get paused with error message : Import Error : No module named infogami .

Errors while building the first image in step 17 :

expectation

git modules should be downloaded and synchronise simultaneously !

Operating system?
Ubuntu 16.04
Docker version 18.09.1

i don't have much idea of the codebase yet .. i am a new comer here and i am opening an issue here for the very first time !

Stakeholders

@mekarpeles @cdrini @hornc

[tfmorris]

The other issue has some useful debugging information on it, including the configuration of the submodules with some of them using git:// URLs and others using https://.

Can you clone repos from Github via the git: protocol? ie do you have an account with SSH keys set up and any other necessary stuff? Can you clone those submodules by hand using the URLs that in the .gitsubmodules file?

We should probably just switch all the URLs to http: for the submodules. That may be enough to avoid problems like this.

[ayushnawal]

@mek @tfmorris @tabshaikh i think atleast updating the installation instructions by adding a line to recommend new contributors to clone the OL repo using git ssh will do the work for now ! i think we were assuming it to be quite obvious but it might not be the same case for everyone out there !

[tfmorris]

All of my repos are cloned using the git protocol, not https, and they work fine. Can you please answer my questions above so that we can try to understand what the actual problem is? (Unless someone else has already figured out the root cause and can add it here).

[Batey96]

I have had same problem but below steps fixed the problem:
-make sure you have ssh keys setup for your github account
-Do a recursive clone when cloning ol through ssh(git clone --recurse-submodules)
finall:continue with the images building

[mekarpeles]

resolved in readme

[yash-gupta2000]

I'm still facing same issue even after following all steps.
@mekarpeles