Openlibrary: Lists are broken: Adding subject to list throws JS error

Created on 8 Oct 2018  路  9Comments  路  Source: internetarchive/openlibrary

Visit https://openlibrary.org/subjects/science
Scroll to "add to list" and try to add the subject to a new list.

When hitting save in the overlay that opens, I hit a JS error.
Seems to be a misnamed variable.

VM300:1 Uncaught ReferenceError: pageurl is not defined
    at <anonymous>:1:1
(anonymous) @ VM300:1
science:1773 Uncaught ReferenceError: pageurl is not defined
    at reload_widget (science:1773)
    at Object.success (science:1845)
    at I (vendor.js?v=2ea74a8f8aba88d7fa77b786c5561d57:19)
    at N (vendor.js?v=2ea74a8f8aba88d7fa77b786c5561d57:19)
Good First Issue JavaScript Regression

All 9 comments

Hi.. Can I work on this issue?

Go for it!

@mekarpeles @Redarcher9 looks like this impacts https://openlibrary.org/works/OL54153W/American_claimant as well. Probably needs hot fixing once resolved... seems important.

List functionality broken.

@Redarcher9 how are you getting on with this issue?

Sorry I didn't get time to work on this issue.

@Redarcher9 hey are you working on this?

@changezkhan Nope... Feel free to assign it to someone else

@Redarcher9 I'll take it then. Thanks btw.

Apologies -- this is a critical bug affecting users and I have a working solution so I think I'm going to step in w/ a fix!

Sorry to step on anyone's toes! <3

Was this page helpful?
0 / 5 - 0 ratings

Related issues

cdrini picture cdrini  路  5Comments

BrittanyBunk picture BrittanyBunk  路  5Comments

cdrini picture cdrini  路  5Comments

cdrini picture cdrini  路  4Comments

BrittanyBunk picture BrittanyBunk  路  4Comments