Openlibrary: Correct how bookreviews CSS is loaded

Created on 5 Oct 2018  路  10Comments  路  Source: internetarchive/openlibrary

@weatherwaxed found this file while working on #1261:
openlibrary/plugins/bookrev/files/css/bookreviews.css

I see 2 possible (but possibly broken) usages:

openlibrary/plugins/bookrev/templates/addreview.html
6:$add_stylesheet('/static/css/bookreviews.css')

openlibrary/plugins/bookrev/templates/type/bookreview/view.html
6:$add_stylesheet('/static/css/bookreviews.css')

Are these working?

We should move openlibrary/plugins/bookrev/files/css/bookreviews.css into static/css/ if they are legitimate entry points as right now this file is hidden away. A new file page-book-reviews.css should be added that loads the css needed.

If the file is not needed we should remove it and all references to it.

Good First Issue CSS Review

All 10 comments

@jdlrobson apart from moving bookreview.css, what do you mean by "if it's broken we should also fix this"?

Does the edit help?

@jdlrobson Shall I take this up?

Go for it!

@usmanmuhd are you still interested in working on this? If so anything I can help with?

Yeah, I wasn't able to setup the docker still.

@usmanmuhd would love to help.
Which bit of https://github.com/internetarchive/openlibrary/blob/master/docker/README.md do you get stuck on?

I was getting ip not found error during setting up docker 91.189.88.152 and when i changed the network and ran again it gave hash mismatch error.

@usmanmuhd could you create a new issue? Be sure to include your OS, version of docker, what commands you ran, and the output you got back.

@mek are book reviews in production?

If not I'd love to see openlibrary/plugins/bookrev/code.py and all associated code removed while we tame this codebase and build some better foundations to build on top of.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

cdrini picture cdrini  路  5Comments

jdlrobson picture jdlrobson  路  5Comments

Pratyush1197 picture Pratyush1197  路  3Comments

BrittanyBunk picture BrittanyBunk  路  5Comments

BrittanyBunk picture BrittanyBunk  路  5Comments