Openlibrary: read-options panel is misaligned

[ghost]

panel is misaligned

[jdlrobson]

Can you post a link of where you are seeing this so I can replicate easily?

[ghost]

It surely is on dev instance not really sure about prod

[jdlrobson]

What page on dev instance are you looking at ?

From what I can see, the issue here is this rule:
.Tools .btn-notice { margin: 35px; }

Your patch only fixes this because #read-options is a more specific selector than .Tools .btn-notice (ids trump classes)

I think instead of overriding in this fashion it would be better to remove/update the .Tools .btn-notice rule.

[ghost]

Here is a screenshot with margin: auto. It competes with .Tools .btn-notice and takes precedence as I wrote in [pull]

[ghost]

Leaving out margin-left does not help:

Instead adding margin: auto:

Is that clear?

[ghost]

What page on dev instance are you looking at ?

From what I can see, the issue here is this rule:
.Tools .btn-notice { margin: 35px; }

Your patch only fixes this because #read-options is a more specific selector than .Tools .btn-notice (ids trump classes)

I think instead of overriding in this fashion it would be better to remove/update the .Tools .btn-notice rule.

This is wrong as .Tools .btn-notice does not apply here.

[jdlrobson]

Is the margin of 35px on .Tools .btn-notice needed anywhere? If so, where?

[ghost]

I can only see class="btn-notice" in macros/databarWork.html and it is referenced in:

• css/components/editions.less
• css/components/Tools.less

Macro databarWork.html is used in templates:

• openlibrary/templates/type/edition/view.html
• openlibrary/templates/type/work/view.html
• openlibrary/templates/type/edition-history/view.html

but nowhere with that order namely .Tools > .btn-notice so I'd say that rule is not used.

[jdlrobson]

Thanks for the detective work!

[jdlrobson]

This issue can be replicated on https://openlibrary.org/works/OL17799873W/Robinson_Crusoe_Robinson_Crusoe

[jdlrobson]

I can't replicate this any more... did this get fixed?

[ghost]

I can't reproduce anymore. Voting to close