Openkore: [Solved] Longer Time to Calculate Master Position.

[Fadreus]

------------------ Bug Report Template ------------------

Summary:

Slave following master took longer time to start following master once lost _(approximately more than 10 seconds to start following back to normal.)_ Early version of Openkore 2.1 doesn't have this behavior _(as long as I remember)_

Impact:

Slave always left behind; going back and forth trying to get to master.

Expected Behavior:

Immediately move to master's last position.
Start following master when found.

Actual Behavior:

Once master lost, it just standing for few seconds (usually 3) trying to calculate master coordinates.
When master is found, it still moving to the calculated coordinates rather than start following.

Steps to Reproduce:

-Master moving without any concern of slave.
-Set slave to follow moving master (Especially Arch Bishop, but normal priest also can )

Additional info:

My current solution is to clear AI when ever master is found. This immediately follow master once found instead of passing through master. I hand-play with Slave AB.

[Fadreus]

Or #1684 would fix this?

[Nipodemos]

1684 will not fix this

[lututui]

Closed accidentally, sorry :3

[c4c1n6kr3m1]

that still moving while found master is an old bug
AI::clear(qw/move route/) when master is found

[Nipodemos]

AI::clear(qw/move route/)

@c4c1n6kr3m1
so, it's just someone put this line of code in the correct place to solve part of the problem?

[ghost]

https://github.com/OpenKore/openkore/blob/04f115473fd91ecd19b34aa60d6a72f16ce7044c/plugins/needs-review/busFollow/trunk/doc/README.txt

ai_follow_lost_end 10 #default value in timeout

Slave following master took longer time to start following master once lost (approximately more than 10 seconds to start following back to normal.)

I checked it before for something in timeouts, but no success. But now, i found ><

[Fadreus]

Still, have no idea where to put this AI::clear(qw/move route/)

[Nipodemos]

@Fadreus in the piece of code that writes the message
"Found my master!"
at least i think so

[Fadreus]

@Nipodemos I thought it was something like this;

# if we are not following now but master is in the screen...
    if (!defined $args->{'ID'}) {
        for my Actor::Player $player (@$playersList) {
            if (($player->name eq $config{followTarget}) && !$player->{'dead'}) {
                $args->{'ID'} = $player->{ID};
                $args->{'following'} = 1;
                $args->{'name'} = $player->name;
                message TF("Found my master - %s\n", $player->name), "follow";
                AI::clear(qw/move route/);
                last;
            }           
        }
    } elsif (!$args->{'following'} && $players{$args->{'ID'}} && %{$players{$args->{'ID'}}} && !${$players{$args->{'ID'}}}{'dead'} && ($players{$args->{'ID'}}->name eq $config{followTarget})) {
        $args->{'following'} = 1;
        delete $args->{'ai_follow_lost'};
        message TF("Found my master!\n"), "follow";
        AI::clear(qw/move route/)
    }

... but not sure if it right. _(iRO server still down to test)_
😥😥😥😥😥

[Nipodemos]

@Fadreus that seems ok to me! but i'm not very good on openkore, at least the syntax is correct, i can't give you sure this will work :confused:

[c4c1n6kr3m1]

put the code before the message , so logically , a line faster
while in master-slave mode, i use low ai_follow_lost_end , i don't care what people say, i made my slave bot walk like client does , bump the master every time master made a single tiny step
and remember the risk

[Fadreus]

• ai_follow_lost_end 1
• AI::clear(qw/move route/)

These seems to fix the time taken to find master & start following master once found.
It just that now looking more weird 😆 when things getting mobby with Position Bug and Skill didn't check LOS. More or less, this increase support efficiency greatly _(at least to me, that is)_

Thanks. Now, leveling to 175 does't seems hard with quick-witted slaves 😁.

[Nipodemos]

you coud do a pull request with this line you inserted :smile:

[Fadreus]

Okies.. 😸