Openkore: party create error

[adraaawr]

iRO: Restart
Problem on creating party using kore,

party request works when you are already a party leader. Need fix. Thx

[sctnightcore]

Download new openkore and test again ! .

[adraaawr]

@sctnightcore I am using the latest openkore.

[sctnightcore]

@adraaawr Did you edit timeout.txt? I think you should re-download and test again.
@alisonrag

[alisonrag]

its not relationed to timeouts, maybe the party is not unset whe you leave

[adraaawr]

Nope, its fresh openkore folder @sctnightcore , when you type 'party leave' in kore, nothing happens. I tried using the old commands.pm - and it works.

[sctnightcore]

party [<info|create|join|request|leave|share|shareitem|sharediv|shareauto|kick|leader>]
I think you should try new.
You can upload old commands.pm?

[adraaawr]

I tried the new one, I fetched openkore multiple times, and party create <partyname> dont work, i need to manually create a party ingame to invite my bots using kore.

But the old commands.pm party create works.

Commands.zip

[Fadreus]

I tested PR from #1383 .
When leaving party, it actually leave but kore didn't recognize it.
Relogging solved this issue.

Same ID, different src/Commands.pm

After relogging

Tested in IRO - Chaos Renewal

[lututui]

I can't reproduce it

This test was made in bRO

[Fadreus]

@lututui Guess it doesn't work for all servers? :thinking: :thinking:
@adraaawr You can revert to previous version for file src/Commands.pm if you need fast solution since it only enhancement.

[adraaawr]

@fadreus , thanks. Im currently using the previous version of the Commands.pm, will wait for further updates. thanks!

[lututui]

Even though the bug report template asks you to post this, you clearly ignored it: what server it this?

[adraaawr]

@lututui , sorry. iRO restart. im new here in github, thought that was just a note. will do better next time.

[sctnightcore]

Please use the issue template, please post infornations about the server and your configuration.

[lututui]

This problem is not about #1383, but rather why $char->{party} is not getting deleted when we leave the party in iRO Restart

[sctnightcore]

openkore/src/Network/Send/iRO.pm @lututui

    my %handlers = qw(
        sync 0360
        character_move 035F
        actor_info_request 0368
        actor_look_at 0361
        item_take 0362
        item_drop 0363
        storage_item_add 0364
        storage_item_remove 0365
        skill_use_location 0366
        party_setting 07D7 << ? 
        buy_bulk_vender 0801
        char_delete2_accept 098f
        send_equip 0998
    );
    $self->{packet_lut}{$_} = $handlers{$_} for keys %handlers;

    $self->{char_create_version} = 0x0A39;

    return $self;
}

I just guess

[lututui]

@fadreus could you repeat the test you made in the top right image, but replace sub party_leave in src/Network/Receive/ServerType0.pm with this one https://gist.github.com/lututui/0706cfc547654f92daec4918277db7c8

@sctnightcore it's not a packet problem, we're actually leaving the party

[Fadreus]

https://gist.github.com/lututui/0706cfc547654f92daec4918277db7c8

@lututui Seems fine with that :thinking: :thinking: :thinking: though it print !�R (Not sure mine or that servertype cause this)

[lututui]

@fadreus I did nothing to it though, I just added the message printing to see if both values were equal, which makes me worried. Is perl inconsistently autovivifying $char->{party}?

Which perl version are you running, or are you using start.exe?

[Fadreus]

@lututui It only appear when leaving party. My Perl is v5.24.1 but I use start.exe.

[lututui]

@fadreus @adraaawr I think #1409 fixes this

[Fadreus]

Fixed with #1409 👌👌👌
☺️☺️☺️

[alisonrag]

Fixed