Openkore: Autostorage broken

[k1nt4r0]

@Henrybk sir, i download the openkore today 24 july 2017
and when my char talk to npc to change map on training ground it got error and dc

This program has encountered an unexpected problem. This is probably because
of a recent server update, a bug in this program, or in one of the plugins.
We apologize for this problem. You may get support from IRC or the forums.

A detailed error report has been saved to errors.txt. Before posting a bug
report, please try out the SVN version first. If you are already using the SVN
version, search the forums first to see if your problem had already been
solved,
or has already been reported. If you truly believe you have encountered a bug
in
the program, please include the contents of the errors.txt in your bug report,
or we may not be able to help you!

The error message is:
Assertion (Argument head should be defined for packet actor_look_at) failed!
at E:/Games/Ragnarok/BOT/Bot ReRO/src/deps/Carp/Assert.pm line 271
Carp::Assert::assert('', 'Argument head should be defined for packet
actor_look_at') called at src/Network/PacketParser.pm line 192

Network::PacketParser::reconstruct('Network::Send::iRO=HASH(0x66198ec)',
'HASH(0x6871604)') called at src/Network/Send.pm line 600
Network::Send::sendLook('Network::Send::iRO=HASH(0x66198ec)', 4, undef)
called at src/AI/CoreLogic.pm line 372
AI::CoreLogic::processLook() called at src/AI/CoreLogic.pm line 71
AI::CoreLogic::iterate() called at src/functions.pl line 769
main::mainLoop_initialized() called at src/functions.pl line 75
main::mainLoop() called at src/Interface.pm line 75
Interface::mainLoop('Interface::Console::Win32=HASH(0x494824c)') called
at openkore.pl line 97
main::__start() called at start.pl line 136
Press ENTER to exit this program.

how to fix this?

[k1nt4r0]

@Henrybk i got fix by ur update btw https://github.com/OpenKore/openkore/commit/b56dda3a62ece0a308ddfdbba1ae1cd49e60d202

but now the openkore cant sell item and error with the storage system

[console] Ready to start selling items
[ai_npcTalk] Done talking with NPC Tool Dealer (1).
[console] Sell failed.
[console] Sell failed.
[console] Sell failed.
[console] Sell failed.
[console] Sell failed.
[console] Sell failed.
[console] Sell failed.
[console] Sell failed.
[success] Auto-sell sequence completed.

[Henrybk]

Please try this pull request: #749

I hope it will fix your problem

[k1nt4r0]

@Henrybk yeah it work fine now :D
but the storage function still error

[lututui]

I can reproduce it. Storage gets opened but nothing happens

edit
Sorry for closing the issue; GitHub mobile webpage is wonky >.<

[xSorux]

GetAuto (config.txt) still seems to be working properly for me.
Depositing based on items_control.txt does not.

[k1nt4r0]

i mix the old bot that i use for Chaos server with the new for re:start and it all work well
but i cant add the achievement packet on it.
so i still get the unknown packet

Packet Parser: Unhandled Packet: 0A23 Handler: achievement_list

but all work well :D

[xSorux]

pulled #758 , same as before. GetAuto works, no deposits happening. iRO Re:start.

[Henrybk]

@xSorux I just tested it in Re:start (since is the server I actually play and bot) and it is working as expected.

Proof: https://i.gyazo.com/af0535672f878ef30977eba3d8b1ca86.png

[xSorux]

Edit: After some more testing, the items that are supposed to be put in storage are not even mentioned in console (debug 2).

[xSorux]

I might have found the reason for the problem. I can't fix it though. I am able to reproduce it.
You can not deposit ammunition while it is equipped, which explains why it does not work.
I am not sure if the map changed is required for it to happen. Screenshots are from the inventory screen provided by wxstart.

[Dalamar6]

It wouldn't deposit my strawberries either. Friend kept insisting "no no it's not a change in the code". Yeah, right. My desktop's older version works fine.

re:start

[k1nt4r0]

i trying this : https://github.com/OpenKore/openkore/pull/758/files/9cde6cf66aaa189648aebf88d338073f6794447b
fix but still not working for storage, when talking it not store anything into storage and get dc sir

[xSorux]

@k1nt4r0 #769 fixes the issue, i tested it on iRO Restart and it works.

[Dalamar6]

Did you test it with strawberry? How was such a fail code change even approved

[kaliwanagan]

It gets approved because people like you don't help test out the changes :)