Openjdk-tests: External jenkins test job images failed to create and didn't fail the build_image steps

[sophia-guo]

Jobs failed at compiling stage but get BUILD SUCCESSFUL and continued to run test stage.

https://ci.adoptopenjdk.net/view/Test_external/job/Test_openjdk11_hs_extended.external_x86-64_linux_jenkins/30/console

23:15:29       [exec]  ---> ea5c394c8d3b
23:15:29       [exec] Step 8/21 : RUN apt-get update    && apt-get install -y --no-install-recommends git maven     && rm -rf /var/lib/apt/lists/*
23:15:29       [exec]  ---> Running in c55b0d10c17e
23:15:30       [exec] no status provided on response: unknown
23:15:30       [exec] Result: 1
23:15:30  
23:15:30  dist:
23:15:30       [copy] Copying 2 files to /home/jenkins/workspace/Test_openjdk11_hs_extended.external_x86-64_linux_jenkins/jvmtest/external/jenkins
23:15:30  
23:15:30  BUILD SUCCESSFUL
23:15:30  Total time: 45 seconds
23:15:30  0

[2001asjad]

Hi @karianna @sophia-guo I want to work on this issue. Can you please guide me more in this issue like what files to look for etc.
I am an Outreachy applicant.
Thank You

[smlambert]

This is reported against external/jenkins jobs (ones running in weekly automation are here: https://ci.adoptopenjdk.net/view/Test_external/job/Test_openjdk11_hs_extended.external_x86-64_linux_jenkins), though it is likely more pervasive than just the external/jenkins tests.

A place to start on this one is to look at external/build.xml and external/jenkins/build.xml to see how the test target is built.

I suspect that the 'build_image' target, which calls a shell script (external.sh) should be changed to fail on error. external.sh may also need to be changed to produce errors when things fail.
Correction: it does have a fail on error statement (see: https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/external/build.xml#L87), so the only thing that is needed is for the external.sh script to be changed to actually fail with an error when they occur.