Openjdk-tests: Enhancement: Transition JCK logic in testJobTemplate into jck.mk

[adamfarley]

Currently, there's some jck code in testJobTemplate.

if (GROUP == "jck" && JDK_IMPL == "openj9") {
    EXTRA_OPTIONS = "-Xfuture"
    if (JDK_VERSION != "8") {
        EXTRA_OPTIONS += " --enable-preview"
    }
    if (ARCH_OS == "s390x_zos") {
        // zOS has Attach API disabled by default
        EXTRA_OPTIONS += " -Dcom.ibm.tools.attach.enable=yes"
    }
}

This issue covers moving that into jck.mk, and any related changes.

As mentioned in https://github.com/AdoptOpenJDK/openjdk-tests/pull/1753

📋 Step by Step

To solve this issue and contribute a fix you should check the following step-by-step list. A more detailed documentation of the workflow can be found here.

• [ ] Claim this issue: Comment below.
• [ ] Fork the openjdk-test in github by simply clicking the 'fork' button.
• [ ] Check out the forked repository
• [ ] Using any kind of git client (command line, Git plugin on Eclipse IDE, etc) create a feature branch off of your fork for the issue. We do not have any naming definition for branches.
• [ ] At this point, you'd have a local clone of openjdk-test](https://github.com/AdoptOpenJDK/openjdk-tests). Update the jck.mk file with your change in the local clone.
• [ ] Commit your changes.
• [ ] Start a Pull Request.
• [ ] Done 👍 Ask in comments for a review :)
• [ ] If the reviewers find some missing peaces or a problem, s/he will start a discussion with you and describe the next steps how the problem can be solved.
• [ ] You did it 🎉 We will merge the fix in the master branch.
• [ ] Thanks, thanks, thanks for being part of this project as an open source contributor ❤️

🤔❓ Questions

If you have any questions just ask us directly in this issue by adding a comment. You can join our community chat at Slack. Next to this you can find a general manual about open source contributions here.

[vanichitkara]

Hi, can I know more details on this issue since I'd like to work on it. Thanks!

[smlambert]

The requirement here is to move logic from a Jenkins groovy script, testJobTemplateL154-165 into the jck/jck.mk file.

This comment may be helpful, as it describes how the openjdk/openjdk.mk file was updated for something similar:
https://github.com/AdoptOpenJDK/openjdk-tests/pull/1753#issuecomment-619077491

[ellschi]

Hi @vanichitkara! Are you still interested in working on this issue? If not I'd take it. :)

[vanichitkara]

Hi @ellschi! You can take up this issue since I have 2 more issues to work on at the moment

[ellschi]

Great @vanichitkara, thank you for letting me know! @adamfarley, @smlambert Please assign me :)

[ellschi]

Ready for review!

[adamfarley]

@ellschi - Heya. Are you asking someone to review a Pull Request?

If so, please add them as reviewers in the Pull Request and paste a PR link in this issue.

[smlambert]

@adamfarley - not sure that new contributors have the ability to add reviewers and brand new contributors would not know who to add as reviewers. Rest assured as the core-team in Ottawa start their day, they know to assist in reviewing the PR backlog of this repo.

[smlambert]

@ellschi - I do not see a PR from you, if you have changes in a branch, please create a PR so we can review, thanks!

[ellschi]

@smlambert: Thank you for the feedback! I created this PR and now am unsure if this was the right way to do it...