Openjdk-infrastructure: Replace win2008 machines with win2012

[gdams]

Once https://github.com/AdoptOpenJDK/openjdk-build/pull/1638 lands we will no longer need win2008R2 build machines.

My proposal is that we replace them with two new 2012 machines so that we have a larger pool of 2012.

Steps:

• [x] Merge https://github.com/AdoptOpenJDK/openjdk-build/pull/1638
• [x] Spin up 2 new 2012 machines (leave 2008 running for now)
• [x] Destroy old Softlayer JCK machine
• [x] Run Ansible on them and add to jenkins
• [x] Ensure that builds run on them
• [x] Remove 200R2 machines are a few weeks

[gdams]

We do also have a JCK windows machine that we should re-purpose at the same time (https://github.com/AdoptOpenJDK/openjdk-infrastructure/blob/master/ansible/inventory.yml#L190)

[Willsparker]

I'm happy to run the playbooks on them and confirm builds run on them 👍

[gdams]

@tellison has confirmed that the JCK machine still exists so I've requested that he re-provision it as a fresh image

[tellison]

Have we checked with the OpenJ9 folks about their build requirements on Windows?

[gdams]

@tellison all of the OpenJ9 builds are running on win2012 the only thing that was still using 2008 is JDK8u Hotspot

[gdams]

two Azure 2012R2 machines have been handed to @Willsparker

[gdams]

https://ci.adoptopenjdk.net/computer/build-azure-win2012r2-x64-1/
https://ci.adoptopenjdk.net/computer/build-azure-win2012r2-x64-2/

both added to jenkins

[tellison]

The old Softlayer JCK machine has been decommissioned, and a shiny new test machine provisioned in its place. Name is test-win2012-2.adoptopenjdk.net and details sent privately to @gdams in the first instance to share with infra team.

[Willsparker]

The 2 new build-azure-2012r2-x64 machines have had the playbook ran on them, and are connected to Jenkins

[gdams]

Installer jobs failing with:

Expand-Archive : The term 'Expand-Archive' is not recognized as the name of a 
cmdlet, function, script file, or operable program. Check the spelling of the 
name, or if a path was included, verify that the path is correct and try again.

this is because the machines had PowerShell 4.0 rather than 5.

To fix I installed WMF 5.1 on both machines (https://docs.microsoft.com/en-gb/powershell/scripting/wmf/setup/install-configure?view=powershell-7)

[gdams]

Shortnames were not enabled on drive C:

fix:

fsutil 8dot3name set C: 0
fsutil file setshortname "C:\Program Files (x86)\WiX Toolset v3.14" WIXTOO~1.14

fsutil file setshortname "C:\Program Files (x86)\Microsoft Visual Studio" MIB055~1
fsutil file setshortname "C:\Program Files (x86)\Microsoft Visual Studio 10.0" MICROS~3.0
fsutil file setshortname "C:\Program Files (x86)\Microsoft Visual Studio 11.0" MICROS~4.0
fsutil file setshortname "C:\Program Files (x86)\Microsoft Visual Studio 12.0" MICROS~1.0
fsutil file setshortname "C:\Program Files (x86)\Microsoft Visual Studio 14.0" MI0E91~1.0
fsutil file setshortname "C:\Program Files (x86)\Microsoft Visual Studio 9.0" MICROS~2.0

fsutil file setshortname "C:\Program Files (x86)\Windows Kits" WINDOW~4

shortnames can be verified with cmd /c for %A in ("C:\Program Files") do @echo %~sA

[gdams]

missing the codesign cert. @Willsparker is creating a new role for this

[gdams]

builds all passing, there is some work to automate the steps above.

[gdams]

All manual steps listed above have now been automated, big thank you to @Willsparker for all the hard work!

[gdams]

2008R2 machines have been destroyed, I left a disk image that we can use to bring back up if we need to