Openjdk-infrastructure: Experiment with playbook format/layout roles/tasks

[bblondin]

I believe that we have outgrown the currently format/layout.
Initially we thought the playbooks for OS deploys would be small/simple.
They have become very lengthy as our requirements have expanded.

It appears that it’s time to look into evolving the playbooks to use roles, task and vars.

I will be experimenting with the Ansible playbooks format/layout.

[gdams]

The Node.js Foundation use this sort of system https://github.com/nodejs/build/tree/master/ansible

[bblondin]

Here is what I have so far:
https://github.com/bblondin/openjdk-infrastructure/tree/master/New_Play

What do you think? Comments/Questions?

This new playbook will be for all Linux systems on all architectures

[karianna]

@bblondin That is looking really good.

[gdams]

I'm certainly liking how it works

[bblondin]

• Added Playbook support for Oracle Linux 7 on aarch64
• Included gcc 4.8 for RedHat 6 on x86_64
• Fixed spelling error in 'ccache' section and updated to use stat.isdir, now skips if already installed
• Fixed version comparison in 'cmake' and 'GIT_Source' roles
• Added 'enable: yes' for NTP[d] service

[gdams]

Can we have windows support in this format? Also macos support would be good!

[gdams]

I wrote the macOS scripts for the Node.js foundation here https://github.com/nodejs/build/pull/971/files

[bblondin]

The 'Nagios_Plugins' role needs some work. I'll have a look at this selection next week.

Such as:

• The way it adds a new user
• How it download loads plugins
• Consistency in layout and format

[tellison]

I'd encourage you to go live with it in the infra repo as soon as you are ready Brad. No point in trying to keep two styles going side-by-side when you have general agreement that this is goodness.

[gdams]

yeah I'd agree, let's get this in a PR so we can review and then we should be good to go

[bblondin]

• pull request created #100
• also renamed and moved, {New_Play => ansible/playbooks/AdoptOpenJDK_Linux_Playbook}