Openhab-addons: binding.wifiled does not contain a manifest

[AngelosF]

Following the upgrade to OH 2.3 Stable, users are experiencing the following FeatureInstaller ERROR:

2018-05-28 14:30:31.095 [ERROR] [core.karaf.internal.FeatureInstaller] - Failed installing 'openhab-binding-hue, openhab-binding-exec, openhab-binding-plugwise1, openhab-misc-restdocs, openhab-misc-openhabcloud, openhab-binding-avmfritz, openhab-persistence-influxdb, openhab-ui-habpanel, openhab-binding-netatmo, openhab-transformation-map, openhab-ui-classic, openhab-ui-habmin, openhab-transformation-xslt, openhab-binding-plugwise, openhab-transformation-exec, openhab-ui-paper, openhab-transformation-scale, openhab-binding-samsungtv, openhab-binding-http1, openhab-ui-homebuilder, openhab-misc-market, openhab-transformation-javascript, openhab-binding-weather1, openhab-binding-plex1, openhab-transformation-regex, openhab-transformation-jsonpath, openhab-binding-zwave, openhab-binding-wifiled, openhab-transformation-xpath, openhab-persistence-rrd4j, openhab-ui-basic, openhab-binding-fritzboxtr0641, openhab-binding-astro, openhab-binding-icloud': Error:
    Resource mvn:org.openhab.binding/org.openhab.binding.wifiled/2.3.0 does not contain a manifest

Workaround

disable the loading of the wifiled binding using the addons.cfg file.

Community reference: https://community.openhab.org/t/2-3-0-wifiled-2-3-0-does-not-contain-a-manifest/45566

[AngelosF]

On a clean OH 2.3 system, installing the WifiLED binding also fails with the same ERROR. PaperUI installation is stuck.

2018-05-28 17:05:05.387 [ERROR] [core.karaf.internal.FeatureInstaller] - Failed installing 'openhab-binding-wifiled': Error:
    Resource mvn:org.openhab.binding/org.openhab.binding.wifiled/2.3.0 does not contain a manifest
2018-05-28 17:05:15.805 [ERROR] [core.karaf.internal.FeatureInstaller] - Failed installing 'openhab-binding-wifiled': Error:
    Resource mvn:org.openhab.binding/org.openhab.binding.wifiled/2.3.0 does not contain a manifest
2018-05-28 17:06:15.820 [ERROR] [core.karaf.internal.FeatureInstaller] - Failed installing 'openhab-binding-wifiled': Error:
    Resource mvn:org.openhab.binding/org.openhab.binding.wifiled/2.3.0 does not contain a manifest

Restarting the OH2 service logs the same error but the instance is working

[AngelosF]

downloaded the org.openhab.binding.wifiled-2.3.0.jar on my system and saw that it is corrupted (I can’t even open it up as an archive)

[martinvw]

@pfink is there a way that we can republish this specific jar?

[pfink]

Mhm, bintray was extremely unstable during the release yesterday. Hopefully, this is not the only corrupt artifact... @kaikreuzer: What do you think, should we build this one locally and publish it again?

[kaikreuzer]

The jar ends up at different places: As a single Maven artifact, in the online-repo, in the KAR file...
Are all of those defect? Or maybe only the one in the online-repo? Can we confirm that on a new build, it actually is correct? Sorry, I don't have the time right now to investigate that in detail myself...

[pfink]

Me too, unfortunately. I have nearly no free minute until next week :/ But if someone identifies were the corrupted artifact is, I could simply rebuild it on the Tag and override it in Bintray...

[AngelosF]

I can confirm that on a new build (https://openhab.ci.cloudbees.com/job/openHAB2-Bundles/lastBuild/org.openhab.binding%24org.openhab.binding.wifiled/) the jar works fine

I will investigate now the places where the (broken) 2.3 jar of wifiled binding is stored and report back.

[AngelosF]

First check: MVN Online repo
Broken: https://dl.bintray.com/openhab/mvn/online-repo/2.3/org/openhab/binding/org.openhab.binding.wifiled/2.3.0/

&

https://openhab.jfrog.io/openhab/list/bintray-openhab/online-repo/2.3/org/openhab/binding/org.openhab.binding.wifiled/2.3.0/

[AngelosF]

Second check: (Offline Add-ons KAR)
Broken: openhab-addons-2.3.0.karrepositoryorgopenhabbindingorg.openhab.binding.wifiled2.3.0

https://bintray.com/openhab/mvn/download_file?file_path=org%2Fopenhab%2Fdistro%2Fopenhab-addons%2F2.3.0%2Fopenhab-addons-2.3.0.kar

[wborn]

How did the 2.3.0 openhab2-addons get released @pfink? I can't seem to find any logging about it in the openhab2-release builds.

[martinvw]

If I remember correctly it was the one which is in the sandbox, so maybe:

https://openhab.ci.cloudbees.com/view/Sandbox/job/sandbox-openhab2-release/

[wborn]

I think it was uploaded as part of the failed https://openhab.ci.cloudbees.com/job/openhab2-release/44/

That logging doesn't show anything unusual when it is uploaded:

[openhab2-addons] [INFO] ------------------------------------------------------------------------
[openhab2-addons] [INFO] Building WiFiLED Binding 2.3.0
[openhab2-addons] [INFO] ------------------------------------------------------------------------
[openhab2-addons] [INFO] 
[openhab2-addons] [INFO] --- tycho-packaging-plugin:1.0.0:build-qualifier (default-build-qualifier) @ org.openhab.binding.wifiled ---
[openhab2-addons] [INFO] The project's OSGi version is 2.3.0
[openhab2-addons] [INFO] 
[openhab2-addons] [INFO] --- tycho-packaging-plugin:1.0.0:validate-id (default-validate-id) @ org.openhab.binding.wifiled ---
[openhab2-addons] [INFO] 
[openhab2-addons] [INFO] --- tycho-packaging-plugin:1.0.0:validate-version (default-validate-version) @ org.openhab.binding.wifiled ---
[openhab2-addons] [INFO] 
[openhab2-addons] [INFO] --- directory-maven-plugin:0.2:highest-basedir (directories) @ org.openhab.binding.wifiled ---
[openhab2-addons] [INFO] Highest basedir set to: /scratch/jenkins/workspace/openhab2-release/openhab2-addons
[openhab2-addons] [INFO] 
[openhab2-addons] [INFO] --- maven-resources-plugin:2.4.3:resources (default-resources) @ org.openhab.binding.wifiled ---
[openhab2-addons] [INFO] Using 'UTF-8' encoding to copy filtered resources.
[openhab2-addons] [INFO] skip non existing resourceDirectory /scratch/jenkins/workspace/openhab2-release/openhab2-addons/addons/binding/org.openhab.binding.wifiled/src/main/resources
[openhab2-addons] [INFO] 
[openhab2-addons] [INFO] --- tycho-compiler-plugin:1.0.0:compile (default-compile) @ org.openhab.binding.wifiled ---
[openhab2-addons] [WARNING] Parameter 'useProjectSettings' is set to true, but preferences file '/scratch/jenkins/workspace/openhab2-release/openhab2-addons/addons/binding/org.openhab.binding.wifiled/.settings/org.eclipse.jdt.core.prefs' could not be found!
[openhab2-addons] [INFO] Compiling 11 source files to /scratch/jenkins/workspace/openhab2-release/openhab2-addons/addons/binding/org.openhab.binding.wifiled/target/classes
[openhab2-addons] [INFO] 
[openhab2-addons] [INFO] --- maven-compiler-plugin:3.6.1:compile (default) @ org.openhab.binding.wifiled ---
[openhab2-addons] [INFO] Changes detected - recompiling the module!
[openhab2-addons] [INFO] Nothing to compile - all classes are up to date
[openhab2-addons] [INFO] 
[openhab2-addons] [INFO] --- maven-scr-plugin:1.24.0:scr (generate-scr-scrdescriptor) @ org.openhab.binding.wifiled ---
[openhab2-addons] [INFO] Writing 1 Service Component Descriptors to /scratch/jenkins/workspace/openhab2-release/openhab2-addons/addons/binding/org.openhab.binding.wifiled/target/classes/OSGI-INF/org.openhab.binding.wifiled.internal.discovery.WiFiLEDDiscoveryService.xml
[openhab2-addons] [INFO] Writing 1 Service Component Descriptors to /scratch/jenkins/workspace/openhab2-release/openhab2-addons/addons/binding/org.openhab.binding.wifiled/target/classes/OSGI-INF/org.openhab.binding.wifiled.internal.WiFiLEDHandlerFactory.xml
[openhab2-addons] [INFO] 
[openhab2-addons] [INFO] --- maven-resources-plugin:2.4.3:testResources (default-testResources) @ org.openhab.binding.wifiled ---
[openhab2-addons] [INFO] Using 'UTF-8' encoding to copy filtered resources.
[openhab2-addons] [INFO] skip non existing resourceDirectory /scratch/jenkins/workspace/openhab2-release/openhab2-addons/addons/binding/org.openhab.binding.wifiled/src/test/resources
[openhab2-addons] [INFO] 
[openhab2-addons] [INFO] --- target-platform-configuration:1.0.0:target-platform (default-target-platform) @ org.openhab.binding.wifiled ---
[openhab2-addons] [INFO] 
[openhab2-addons] [INFO] --- tycho-packaging-plugin:1.0.0:package-plugin (default-package-plugin) @ org.openhab.binding.wifiled ---
[openhab2-addons] [INFO] Building jar: /scratch/jenkins/workspace/openhab2-release/openhab2-addons/addons/binding/org.openhab.binding.wifiled/target/org.openhab.binding.wifiled-2.3.0.jar
[openhab2-addons] [INFO] 
[openhab2-addons] [INFO] --- tycho-p2-plugin:1.0.0:p2-metadata-default (default-p2-metadata-default) @ org.openhab.binding.wifiled ---
[openhab2-addons] [INFO] 
[openhab2-addons] [INFO] --- artifact-spy-plugin:1.0.6:spy (spy) @ org.openhab.binding.wifiled ---
[openhab2-addons] [INFO] 
[openhab2-addons] [INFO] --- maven-install-plugin:2.3.1:install (default-install) @ org.openhab.binding.wifiled ---
[openhab2-addons] [INFO] Installing /scratch/jenkins/workspace/openhab2-release/openhab2-addons/addons/binding/org.openhab.binding.wifiled/target/org.openhab.binding.wifiled-2.3.0.jar to /scratch/jenkins/workspace/openhab2-release/.repository/org/openhab/binding/org.openhab.binding.wifiled/2.3.0/org.openhab.binding.wifiled-2.3.0.jar
[openhab2-addons] [INFO] Installing /scratch/jenkins/workspace/openhab2-release/openhab2-addons/addons/binding/org.openhab.binding.wifiled/pom.xml to /scratch/jenkins/workspace/openhab2-release/.repository/org/openhab/binding/org.openhab.binding.wifiled/2.3.0/org.openhab.binding.wifiled-2.3.0.pom
[openhab2-addons] [INFO] Installing /scratch/jenkins/workspace/openhab2-release/openhab2-addons/addons/binding/org.openhab.binding.wifiled/target/p2content.xml to /scratch/jenkins/workspace/openhab2-release/.repository/org/openhab/binding/org.openhab.binding.wifiled/2.3.0/org.openhab.binding.wifiled-2.3.0-p2metadata.xml
[openhab2-addons] [INFO] Installing /scratch/jenkins/workspace/openhab2-release/openhab2-addons/addons/binding/org.openhab.binding.wifiled/target/p2artifacts.xml to /scratch/jenkins/workspace/openhab2-release/.repository/org/openhab/binding/org.openhab.binding.wifiled/2.3.0/org.openhab.binding.wifiled-2.3.0-p2artifacts.xml
[openhab2-addons] [INFO] 
[openhab2-addons] [INFO] --- tycho-p2-plugin:1.0.0:update-local-index (default-update-local-index) @ org.openhab.binding.wifiled ---
[openhab2-addons] [INFO] 
[openhab2-addons] [INFO] --- maven-deploy-plugin:2.8.2:deploy (default-deploy) @ org.openhab.binding.wifiled ---
[openhab2-addons] [INFO] Uploading: https://api.bintray.com/maven/openhab/mvn/openhab2-addons/;publish=1/org/openhab/binding/org.openhab.binding.wifiled/2.3.0/org.openhab.binding.wifiled-2.3.0.jar
[openhab2-addons] [INFO] Uploaded: https://api.bintray.com/maven/openhab/mvn/openhab2-addons/;publish=1/org/openhab/binding/org.openhab.binding.wifiled/2.3.0/org.openhab.binding.wifiled-2.3.0.jar (41 kB at 27 kB/s)
[openhab2-addons] [INFO] Uploading: https://api.bintray.com/maven/openhab/mvn/openhab2-addons/;publish=1/org/openhab/binding/org.openhab.binding.wifiled/2.3.0/org.openhab.binding.wifiled-2.3.0.pom
[openhab2-addons] [INFO] Uploaded: https://api.bintray.com/maven/openhab/mvn/openhab2-addons/;publish=1/org/openhab/binding/org.openhab.binding.wifiled/2.3.0/org.openhab.binding.wifiled-2.3.0.pom (837 B at 549 B/s)
[openhab2-addons] [INFO] Downloading: https://api.bintray.com/maven/openhab/mvn/openhab2-addons/;publish=1/org/openhab/binding/org.openhab.binding.wifiled/maven-metadata.xml
[openhab2-addons] [INFO] Downloaded: https://api.bintray.com/maven/openhab/mvn/openhab2-addons/;publish=1/org/openhab/binding/org.openhab.binding.wifiled/maven-metadata.xml (411 B at 758 B/s)
[openhab2-addons] [INFO] Downloading: https://api.bintray.com/maven/openhab/mvn/openhab2-addons/;publish=1/org/openhab/binding/org.openhab.binding.wifiled/maven-metadata.xml
[openhab2-addons] [INFO] Downloaded: https://api.bintray.com/maven/openhab/mvn/openhab2-addons/;publish=1/org/openhab/binding/org.openhab.binding.wifiled/maven-metadata.xml (411 B at 863 B/s)
[openhab2-addons] [INFO] Uploading: https://api.bintray.com/maven/openhab/mvn/openhab2-addons/;publish=1/org/openhab/binding/org.openhab.binding.wifiled/maven-metadata.xml
[openhab2-addons] [INFO] Uploaded: https://api.bintray.com/maven/openhab/mvn/openhab2-addons/;publish=1/org/openhab/binding/org.openhab.binding.wifiled/maven-metadata.xml (415 B at 492 B/s)
[openhab2-addons] [INFO] Uploading: https://api.bintray.com/maven/openhab/mvn/openhab2-addons/;publish=1/org/openhab/binding/org.openhab.binding.wifiled/maven-metadata.xml
[openhab2-addons] [INFO] Uploaded: https://api.bintray.com/maven/openhab/mvn/openhab2-addons/;publish=1/org/openhab/binding/org.openhab.binding.wifiled/maven-metadata.xml (415 B at 625 B/s)
[openhab2-addons] [INFO] Uploading: https://api.bintray.com/maven/openhab/mvn/openhab2-addons/;publish=1/org/openhab/binding/org.openhab.binding.wifiled/2.3.0/org.openhab.binding.wifiled-2.3.0-p2metadata.xml
[openhab2-addons] [INFO] Uploaded: https://api.bintray.com/maven/openhab/mvn/openhab2-addons/;publish=1/org/openhab/binding/org.openhab.binding.wifiled/2.3.0/org.openhab.binding.wifiled-2.3.0-p2metadata.xml (2.8 kB at 1.9 kB/s)
[openhab2-addons] [INFO] Downloading: https://api.bintray.com/maven/openhab/mvn/openhab2-addons/;publish=1/org/openhab/binding/org.openhab.binding.wifiled/maven-metadata.xml
[openhab2-addons] [INFO] Downloaded: https://api.bintray.com/maven/openhab/mvn/openhab2-addons/;publish=1/org/openhab/binding/org.openhab.binding.wifiled/maven-metadata.xml (415 B at 1.6 kB/s)
[openhab2-addons] [INFO] Uploading: https://api.bintray.com/maven/openhab/mvn/openhab2-addons/;publish=1/org/openhab/binding/org.openhab.binding.wifiled/maven-metadata.xml
[openhab2-addons] [INFO] Uploaded: https://api.bintray.com/maven/openhab/mvn/openhab2-addons/;publish=1/org/openhab/binding/org.openhab.binding.wifiled/maven-metadata.xml (415 B at 489 B/s)
[openhab2-addons] [INFO] Uploading: https://api.bintray.com/maven/openhab/mvn/openhab2-addons/;publish=1/org/openhab/binding/org.openhab.binding.wifiled/2.3.0/org.openhab.binding.wifiled-2.3.0-p2artifacts.xml
[openhab2-addons] [INFO] Uploaded: https://api.bintray.com/maven/openhab/mvn/openhab2-addons/;publish=1/org/openhab/binding/org.openhab.binding.wifiled/2.3.0/org.openhab.binding.wifiled-2.3.0-p2artifacts.xml (561 B at 383 B/s)
[openhab2-addons] [INFO] Downloading: https://api.bintray.com/maven/openhab/mvn/openhab2-addons/;publish=1/org/openhab/binding/org.openhab.binding.wifiled/maven-metadata.xml
[openhab2-addons] [INFO] Downloaded: https://api.bintray.com/maven/openhab/mvn/openhab2-addons/;publish=1/org/openhab/binding/org.openhab.binding.wifiled/maven-metadata.xml (415 B at 1.4 kB/s)
[openhab2-addons] [INFO] Uploading: https://api.bintray.com/maven/openhab/mvn/openhab2-addons/;publish=1/org/openhab/binding/org.openhab.binding.wifiled/maven-metadata.xml
[openhab2-addons] [INFO] Uploaded: https://api.bintray.com/maven/openhab/mvn/openhab2-addons/;publish=1/org/openhab/binding/org.openhab.binding.wifiled/maven-metadata.xml (415 B at 504 B/s)

It got downloaded again without warnings from https://jcenter.bintray.com/org/openhab/binding/org.openhab.binding.wifiled/2.3.0/org.openhab.binding.wifiled-2.3.0.jar which is also corrupt in https://openhab.ci.cloudbees.com/job/openhab2-release/51/

[INFO] Downloading: https://repository-openhab.forge.cloudbees.com/release/org/openhab/binding/org.openhab.binding.wifiled/2.3.0/org.openhab.binding.wifiled-2.3.0.jar
[INFO] Downloading: http://repo1.maven.org/maven2/org/openhab/binding/org.openhab.binding.wifiled/2.3.0/org.openhab.binding.wifiled-2.3.0.jar
[INFO] Downloading: https://jcenter.bintray.com/org/openhab/binding/org.openhab.binding.wifiled/2.3.0/org.openhab.binding.wifiled-2.3.0.jar
[INFO] Downloaded: https://jcenter.bintray.com/org/openhab/binding/org.openhab.binding.wifiled/2.3.0/org.openhab.binding.wifiled-2.3.0.jar (41 kB at 100 kB/s)

A hex viewer shows that the content is just 0x00's:

xxd org.openhab.binding.wifiled-2.3.0.jar | head -n 5
00000000: 0000 0000 0000 0000 0000 0000 0000 0000  ................
00000010: 0000 0000 0000 0000 0000 0000 0000 0000  ................
00000020: 0000 0000 0000 0000 0000 0000 0000 0000  ................
00000030: 0000 0000 0000 0000 0000 0000 0000 0000  ................
00000040: 0000 0000 0000 0000 0000 0000 0000 0000  ................

xxd org.openhab.binding.wifiled-2.3.0.jar | tail -n 5
00009e60: 0000 0000 0000 0000 0000 0000 0000 0000  ................
00009e70: 0000 0000 0000 0000 0000 0000 0000 0000  ................
00009e80: 0000 0000 0000 0000 0000 0000 0000 0000  ................
00009e90: 0000 0000 0000 0000 0000 0000 0000 0000  ................
00009ea0: 0000 0000                                ....

I think the file got corrupt at Bintray because the org.openhab.binding.wifiled-2.3.0.jar.md5 (996dbbf491ee150191811d6599f4cf21) that is stored does not match the md5 of the corrupted file (3b367b97bf45d0de88c83c5757fba4b3). It looks like the md5 file was never uploaded but it got generated from the uncorrupted file at Bintray

[wborn]

Hopefully, this is not the only corrupt artifact

The org.openhab.binding.wifiled-2.3.0.jar is the only JAR that is corrupt after having tested all JARs of the runtime and KAR files.

[pfink]

@wborn: I confirm you picked the right build, thanks for your efforts!

[pfink]

Online Repo is fixed now, KAR will follow soon.

[pfink]

KAR is fixed as well now. FTR, I attach the deleted / replaced files here (I have to skip the KAR because it's too big).

deleted wifiled artifacts.zip

Unfortunately, there is no easy possibility to delete the JFrog cache. For now, I completely disabled the cache and I hope that there is maybe a cron or so which will clear the cache in the next few days so we can reenable afterwards.

Please test and close the ticket if it works fine now.

[martinvw]

@pfink thanks!

[AngelosF]

I can confirm that the online repo provides a working org.openhab.binding.wifiled-2.3.0.jar now !

On my "faulty" system (rPi3 running 2.3.0 Stable), I performed the following steps:
Stop OH2 service
Clear out cache & tmp (which includes: /var/lib/openhab2/tmp/mvn/org/openhab/binding/org.openhab.binding.wifiled/ folder with the faulty jar)
start OH2
The new jar was downloaded again and it started up correctly.
Closing this issue now :)

[tilobes]

I am having problems with this. Have you forgotten to update the .deb packages?

[martinvw]

If I recall correctly @BClark09 should be the one who knows that :-)

[BClark09]

Doing what @AngelosF suggested should work on a standard debian install, but I believe the openhab2-addons package should be removed (so that the openhab2 install is an online one.) Let me know if you're still having trouble though.

[tilobes]

I solved it locally, but i think the debian packages are still wrong. So all people who choose this installation method, will have the same problem in future.