Openfoodnetwork: [release test automation] Review and revamp coverage on Subscriptions

[filipefurtad0]

What we should change and why (this is tech debt)

We should review our current test coverage on this feature and extend it.

Context

We have frequent user reports from bugs on subscriptions. This is a likely symptom of insufficient test coverage.

Impact and timeline

Improves upgrade confidence and release testing confidence - despite recent improvements on the testing routine, it remains a time consuming feature to test manually.

[leamha]

Hi, I'd like to work on this, could you maybe point me in the direction of where the current test is located? I've only been looking at the code base for a day or two so I'm not sure of where everything is yet. Thank you!

[filipefurtad0]

Hi @leamha, welcome!

Thanks for your interest in contributing to our test-suite :muscle:

There are some tests on subscriptions here, for example:
/spec/features/admin/subscriptions_spec.rb

and

/spec/controllers/admin/subscriptions_controller_spec.rb

But I'm not sure this is a good first issue to begin with, as the code around Subsbriptions is quite a tricky.

Maybe you'd like to have a look at somewhat easier tests on the QA Welcome board?

[leamha]

I'll take a look at these first and if I think they're too difficult for me to do a good job on I'll move to the QA Welcome board, thank you for your help!!!

[filipefurtad0]

Sure! I've assigned you to the issue.
Please go ahead and feel free to reach out if you have any questions :+1:

[leamha]

Just updating, I added some test cases to /spec/features/admin/subscriptions_spec.rb and submitted a pull request, however you were certainly correct in saying that the tests are tricky, so I did the most I think I could correctly contribute to and have no clue if my pull request will be accepted. If anyone else with experience with this project wants to take over from here I'm very okay with that, thank you for all your help!

[filipefurtad0]

Thank you for the update and contribution @leamha !

If you haven't done so already, please feel free to drop by to say Hi on our Slack, in the #general channel and join #dev and #testing as well. We're happy to help you get more familiar with the project.