Openfoodnetwork: Error 404 if an OC closes during checkout: /checkout -> /undefined

[filipefurtad0]

Description

A customer adds an item and proceeds to the checkout page. Error 404 will be displayed when the customer attempts to finish the purchase (by pressing the Place order now), if the respective order-cycle closes while the customer is in the /checkout page.

Expected Behavior

Updated: In the case that the order cycle closes mid shopping the user will see an improved error message explaining what happened.

Actual Behaviour

Redirection to the page /undefined - Snail 404

Steps to Reproduce

1. User: populate the cart
2. User: proceed to check-out
3. Admin: close the order-cycle from which some products from the above cart are included
4. User: press Place order now (/checkout)
5. User gets redirected to /undefined - error 404

Workaround

Manually navigating to the previous page will redirect the customer to the shopfront.

Severity

No workaround, but an edge case - s3

Your Environment

• Version used: v2.9.7
• Browser name and version: Firefox 75
• Operating System and version (desktop or mobile): Desktop

Possible Fix

This is perhaps related to issue #5369 , since it also deals with the closing of an order-cycle on during the shopping-journey.

[lin-d-hop]

The agreed solution is that in the case that the order cycle closes mid shopping the user will see an improved error message explaining what happened.

[filipefurtad0]

Thanks for commenting this @lin-d-hop :heart: I'll update the "Expected behaviour" on this.

[Erioldoesdesign]

agreed with the above solution for papercut-ness

buttttttt just noting here how good it would be to have a countdown timer to when the order closes throughout the checkout process. Perhaps like when there's 1 hour till order cycle close theres a message that overlays on that shop.
Lots of online stores do this for sale periods and how long a system remembers items in a basket:

The sale usage of this UI is pretty icky and pushy sales but in this case I think it could be useful to have a timeout. But worth testing with shoppers to be sure.

[filipefurtad0]

Related Bugsnag log:
https://app.bugsnag.com/open-food-france/coopcircuits/errors/609cf8d61cf2950007ce5571?event_id=609d7389007be4c96c350000&i=sk&m=nw