Openfoodnetwork: When crediting an order the transaction fee is applied when it shouldn't

[sstead]

Expected Behavior

I have an order which was paid in full with Stripe. Then I removed an item from the order, putting the order in Credit. I tried to refund this credit using the Credit button. I found that when the credit was applied, the transaction fee that the shop has on Stripe payments was applied to the credit.

I would not expect a payment method transaction fee to be applied to a credit event.

Actual Behaviour

The credit event incurred the transaction fee.

Steps to Reproduce

1. Place an order in a shop and pay with Stripe- where stripe has a payment method fee associated (e.g $5)
2. Go to Orders in the backend and take one item from the order, putting it into credit
3. Go to edit the order and go to payments. Click the credit button.
4. See that the credit was applied but the transaction fee was also applied.

Animated Gif/Screenshot

Context

I'm trying to do a partial refund from the backend.

Severity

bug-s3: a feature is broken but there is a workaround

Your Environment

Product, Aus, Chrome, PC, Desktop

Possible Fix

Credit event should not carry fee.

[sauloperez]

This one is looking at us @luisramos0 :trollface: I wish we could wait until fixing it in v2 but I'm afraid it'll still take some time...

[luisramos0]

well, not really, I think we have to ask:

• is this a fundamental feature in ofn and how much is it used today? most probably it's not used and it has been broken for a while
• will this fix in master work in v2 and thus, there will be no rework when merging to v2? I think the answer is no, we would have to fix in master and then think again about it in v2 with all the changes in adjustments/shipments

So, I'd only fix this one only in v2 if no one disagrees.

[sauloperez]

That's exactly what I meant. We need to know if it can wait for a single v2-fix or not

[kirstenalarsen]

@daniellemoorhead just clearing issues and found this - think is related to your local produce ladies question?

[kirstenalarsen]

not sure if we actually need to act on this or not

[daniellemoorhead]

@daniellemoorhead just clearing issues and found this - think is related to your local produce ladies question?

@kirstenalarsen no, this is different. They were not happy about having to take the hit on the original stripe fee. The stripe website says that they don't charge fees on refunds so it would be worth checking if this is actually an issue anymore, maybe they changed their policy.

https://stripe.com/docs/refunds

[luisramos0]

This can probably be investigated together with https://github.com/openfoodfoundation/openfoodnetwork/issues/5258
Maybe this is not a problem with stripe-sca, feeling optimist :blush:

[luisramos0]

This issue is related to OFN payment method fees, not stripe fees. @daniellemoorhead 's point above is about stripe fees. Refunds in stripe dont have fees. And the stripe fees on the original payments are refunded if the refund is in full, for partial refunds, the original stripe fees are still charged. Which I think makes sense. See my related comments here.

Regarding this issue, I can replicate it, the fee on the payment method is applied a second time when the credit is done.
On a full refund, the second fee is NOT added, only on credit/partial refunds.

This is not directly related to stripe refunds but more to the OFN logic behind them, so I am not going to tackle this one now as part of #5258 (prioritized through StripeSCA epic) and #5449 (bug-S2). This is a normal S3 that needs to be prioritized.

To find out a possible solution, I'd need to investigate. I'll leave that for when the issue is prioritized.

[sigmundpetersen]

So we move this back to All the things?

[luisramos0]

@lin-d-hop can you please make the call if this is part of the scope or not? :-)

[lin-d-hop]

Although this is a long term annoyance it is nothing related to Stripe and definitely related to all payment method fees.

It was optimistic that it was ever thought it might be in scope for Stripe SCA. Definitely out of scope. I wish I'd noticed a dozen comments ago to save all the investigation time ;-)