Openfoodnetwork: Returned inventory is added to the Product On Hand value incorrectly

[sstead]

When products are managed in Inventory...

When a customer orders the product, the stock is subtracted from the Invenotry On Hand value. But if the order is cancelled or the item returned, the stock returns to the Product On Hand value.

This is incorrect, it should continue to treat that item as Inventory, not a Product.

[enricostano]

@sauloperez this is something we could check: if and how it will change with the new inventory implementation in Spree 2.0

[kirstenalarsen]

this makes me wonder if we should maintain a ‘pre-spree-upgrade’ version operating on a staging server somewhere, to make it really easy for people testing to check back whether something is a bug or behaviour introduced by spree upgrade. It can sometimes be challenging (even for the super-human @sstead) to remember the detail of exactly how everything is meant to work / worked before!

On 21 Jun 2017, at 8:04 PM, Enrico Stano [e-mail] wrote:

@sauloperez https://github.com/sauloperez this is something we could check: if and how it will change with the new inventory implementation in Spree 2.0

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/openfoodfoundation/openfoodnetwork/issues/1631#issuecomment-310032083, or mute the thread https://github.com/notifications/unsubscribe-auth/ACxryMNfq7byUSCA4xaL8bj-yoq7VeOFks5sGOqXgaJpZM4OAhfn.

[enricostano]

‘pre-spree-upgrade’ version operating on a staging server

That would be awesome @kirstenalarsen

[daniellemoorhead]

The two staging servers in Aus get used fairly frequently @kirstenalarsen, whether it's for demos or for rob and maikel's stuff - reckon we should spin up another temporary staging server specifically for Spree upgrade?

[enricostano]

This is blocked by Spree upgrade

[luisramos0]

Removing the reference to #2109 and moving it to epic #2584 (all the issues blocked by the spree upgrade).

[luisramos0]

v2 comes with this one fixed 🎉
I have tested in v1 and it is broken, I tested in v2 and it works.
You can have a look at staging AUS.

Testing notes: #wannabetester
https://docs.google.com/document/d/1KU5WBhU6GKPuG35VeoOrec5gti7ICVAD5w3nQVjpQWY/edit

I have additionally verified that resuming the order takes the inventory back again from the right place.
Closing the issue.