Openebs: Rename maya/cmd/apiserver -> maya/cmd/maya-apiserver

Created on 14 Oct 2017  路  6Comments  路  Source: openebs/openebs

It will be good if all the binaries at openebs/maya/cmd of openebs/maya will follow a standard convention.

Similar to kubernetes binaries, it will be good to have apiserver as maya-apiserver.

After renaming the binary name, the associated build scripts at this location also needs to be updated:

Hacktoberfest first-timers-only for-new-contributors good first issue kincleanup

Most helpful comment

If you run make apiserver-image this will build an image to with the new command

All 6 comments

Do you need cmd folder apiserver renamed to maya-apiserver?

Which tests can be runned to make sure everything is ok after renaming the folder?

If you run make apiserver-image this will build an image to with the new command

@SadPandaBear Test with the new apiserver binary that gets generated via make apiserver-image or even make apiserver.
This binary can also be run as its CLI. Just run it & post the various options it displays.

Should we rename the binary generated or just the folder + build script paths needed?

PR is merged for this issue openebs/maya#113

Was this page helpful?
0 / 5 - 0 ratings