Openapoc: No agent matching id AGENT 11

[FilmBoy84]

This is possibly related to #368 and #505 but appeared AFTER a combat mission and several days after a transfer done through the HIRE screen (scientist moved to another base in same transaction as hire and fire some others, see example below as openapoc allows this all in one go, unlike OG)

On leaving a tac mission i am immediately presented with the following

On clicking OK the game presents the following further error

Then crashes, unable to perform a backtrace :(

One agent died in the mission, this was one of the agents provided at game start
This may be relevant?

[JonnyH]

Yeah, that error saying "No ${OBJECT_TYPE} object matching ID ${X} found" is pretty much the last gasp before we know we're going to crash, as it's due to a StateRef<> pointing to something that no longer exists. Nearly always you only lookup a StateRef<> if you're going to use it, and using a bad one /will/ crash.

I'll try to get a similar situation and see if I can repro....

[Quickmind01]

Received this error out of the blue while producing Disruptor Left Arm armor:

I class std::list,class std::allocator > > __cdecl OpenApoc::City::findShortestPath(struct glm::vec<3,int,0>,struct glm::vec<3,int,0>,const class OpenApoc::GroundVehicleTileHelper &,bool,bool,bool,bool): Trying to route from rs 543 to rs 623
I class std::list,class std::allocator > > __cdecl OpenApoc::City::findShortestPath(struct glm::vec<3,int,0>,struct glm::vec<3,int,0>,const class OpenApoc::GroundVehicleTileHelper &,bool,bool,bool,bool): No more road segments to expand after 430 iterations
I class std::list,class std::allocator > > __cdecl OpenApoc::City::findShortestPath(struct glm::vec<3,int,0>,struct glm::vec<3,int,0>,const class OpenApoc::GroundVehicleTileHelper &,bool,bool,bool,bool): Surprisingly, no nodes to expand! Closest path ends at 543
W void __cdecl OpenApoc::StateRef::resolve(void) const: ResearchTopic object has invalid prefix - expected "RESEARCH_" ID "MANUFACTURE_DISRUPTOR_ARMOR_(LEFT_ARM)"
E class std::shared_ptr __cdecl OpenApoc::Agent::get(const class OpenApoc::GameState &,const class OpenApoc::UString &): No agent matching ID "AGENT_2787"
0x0,000,7FF,636,05E,502 +0x140695445038338x

0x0,000,7FF,636,045,EA0 +0x140695444938400x

0x0,000,7FF,636,05E,942 +0x140695445039426x

0x0,000,7FF,636,045,EA0 +0x140695444938400x

0x0,000,7FF,636,045,E06 +0x140695444938246x

0x0,000,7FF,636,280,979 PHYSFS_writeSLE64+0x500873x

0x0,000,7FF,636,0EC,8B0 PHYSFS_writeSLE64+0x18446744073708397504x

0x0,000,7FF,636,278,E02 PHYSFS_writeSLE64+0x469266x

0x0,000,7FF,636,223,51E PHYSFS_writeSLE64+0x118830x

0x0,000,7FF,636,221,FE3 PHYSFS_writeSLE64+0x113395x

0x0,000,7FF,636,224,5E5 PHYSFS_writeSLE64+0x123125x

0x0,000,7FF,636,11D,109 PHYSFS_writeSLE64+0x18446744073708596249x

0x0,000,7FF,636,043,12A PHYSFS_writeSLE64+0x18446744073707703354x

0x0,000,7FF,636,01F,C4E PHYSFS_writeSLE64+0x18446744073707558750x

0x0,000,7FF,636,467,115 PHYSFS_writeSLE64+0x2493477x

0x0,000,7FF,636,207,B10 PHYSFS_writeSLE64+0x5664x

0x0,000,7FF,B31,027,974 BaseThreadInitThunk+0x20x

0x0,000,7FF,B31,C9A,271 RtlUserThreadStart+0x33x

E void __cdecl OpenApoc::StateRef::resolve(void) const: No Agent object matching ID "AGENT_2787" found
0x0,000,7FF,636,05E,502 +0x140695445038338x

0x0,000,7FF,636,045,EA0 +0x140695444938400x

0x0,000,7FF,636,05E,942 +0x140695445039426x

0x0,000,7FF,636,045,EA0 +0x140695444938400x

0x0,000,7FF,636,045,E06 +0x140695444938246x

0x0,000,7FF,636,0EC,9AE +0x140695445621166x

0x0,000,7FF,636,278,E02 PHYSFS_writeSLE64+0x469266x

0x0,000,7FF,636,223,51E PHYSFS_writeSLE64+0x118830x

0x0,000,7FF,636,221,FE3 PHYSFS_writeSLE64+0x113395x

0x0,000,7FF,636,224,5E5 PHYSFS_writeSLE64+0x123125x

0x0,000,7FF,636,11D,109 PHYSFS_writeSLE64+0x18446744073708596249x

0x0,000,7FF,636,043,12A PHYSFS_writeSLE64+0x18446744073707703354x

0x0,000,7FF,636,01F,C4E PHYSFS_writeSLE64+0x18446744073707558750x

0x0,000,7FF,636,467,115 PHYSFS_writeSLE64+0x2493477x

0x0,000,7FF,636,207,B10 PHYSFS_writeSLE64+0x5664x

0x0,000,7FF,B31,027,974 BaseThreadInitThunk+0x20x

0x0,000,7FF,B31,C9A,271 RtlUserThreadStart+0x33x

E class std::shared_ptr __cdecl OpenApoc::Agent::get(const class OpenApoc::GameState &,const class OpenApoc::UString &): No agent matching ID "AGENT_2787"
0x0,000,7FF,636,05E,502 +0x140695445038338x

0x0,000,7FF,636,045,EA0 +0x140695444938400x

0x0,000,7FF,636,05E,942 +0x140695445039426x

0x0,000,7FF,636,045,EA0 +0x140695444938400x

0x0,000,7FF,636,045,E06 +0x140695444938246x

0x0,000,7FF,636,280,979 PHYSFS_writeSLE64+0x500873x

0x0,000,7FF,636,0EC,8B0 PHYSFS_writeSLE64+0x18446744073708397504x

0x0,000,7FF,636,278,E17 PHYSFS_writeSLE64+0x469287x

0x0,000,7FF,636,223,51E PHYSFS_writeSLE64+0x118830x

0x0,000,7FF,636,221,FE3 PHYSFS_writeSLE64+0x113395x

0x0,000,7FF,636,224,5E5 PHYSFS_writeSLE64+0x123125x

0x0,000,7FF,636,11D,109 PHYSFS_writeSLE64+0x18446744073708596249x

0x0,000,7FF,636,043,12A PHYSFS_writeSLE64+0x18446744073707703354x

0x0,000,7FF,636,01F,C4E PHYSFS_writeSLE64+0x18446744073707558750x

0x0,000,7FF,636,467,115 PHYSFS_writeSLE64+0x2493477x

0x0,000,7FF,636,207,B10 PHYSFS_writeSLE64+0x5664x

0x0,000,7FF,B31,027,974 BaseThreadInitThunk+0x20x

0x0,000,7FF,B31,C9A,271 RtlUserThreadStart+0x33x

E void __cdecl OpenApoc::StateRef::resolve(void) const: No Agent object matching ID "AGENT_2787" found
0x0,000,7FF,636,05E,502 +0x140695445038338x

0x0,000,7FF,636,045,EA0 +0x140695444938400x

0x0,000,7FF,636,05E,942 +0x140695445039426x

0x0,000,7FF,636,045,EA0 +0x140695444938400x

0x0,000,7FF,636,045,E06 +0x140695444938246x

0x0,000,7FF,636,0EC,9AE +0x140695445621166x

0x0,000,7FF,636,278,E17 PHYSFS_writeSLE64+0x469287x

0x0,000,7FF,636,223,51E PHYSFS_writeSLE64+0x118830x

0x0,000,7FF,636,221,FE3 PHYSFS_writeSLE64+0x113395x

0x0,000,7FF,636,224,5E5 PHYSFS_writeSLE64+0x123125x

0x0,000,7FF,636,11D,109 PHYSFS_writeSLE64+0x18446744073708596249x

0x0,000,7FF,636,043,12A PHYSFS_writeSLE64+0x18446744073707703354x

0x0,000,7FF,636,01F,C4E PHYSFS_writeSLE64+0x18446744073707558750x

0x0,000,7FF,636,467,115 PHYSFS_writeSLE64+0x2493477x

0x0,000,7FF,636,207,B10 PHYSFS_writeSLE64+0x5664x

0x0,000,7FF,B31,027,974 BaseThreadInitThunk+0x20x

0x0,000,7FF,B31,C9A,271 RtlUserThreadStart+0x33x

[Nekon475]

W void __cdecl OpenApoc::StateRef::resolve(void) const: ResearchTopic object has invalid prefix - expected "RESEARCH_" ID "MANUFACTURE_DISRUPTOR_GUN"

log.txt

save_345.zip

[JonnyH]

@Nekon475 That issue doesn't seem to be related, so I pulled that out as #970