Model properties that are dates generate invalid Java code where a default value is specified.
v5.0.0-beta
{
"openapi": "3.0.1",
"info": {
"title": "Test",
"version": "1.0"
},
"paths": {},
"components": {
"schemas": {
"Request": {
"type": "object",
"properties": {
"endDate": {
"type": "string",
"format": "date",
"default": "1900-01-01"
},
"startDate": {
"type": "string",
"format": "date"
}
}
}
}
}
}
java -jar openapi-generator-cli-5.0.0-beta.jar generate -i test.json -g java -o .\output --additional-properties dateLibrary=java8-localdatetime
Run the command above;
View generated Request.java which contains the following invalid variable initialization:
@javax.annotation.Generated(value = "org.openapitools.codegen.languages.JavaClientCodegen", date = "2020-07-24T10:22:22.238+10:00[Australia/Sydney]")
public class Request {
public static final String SERIALIZED_NAME_END_DATE = "endDate";
@SerializedName(SERIALIZED_NAME_END_DATE)
private LocalDate endDate = 1900-01-01; // <--- Type mismatch: cannot convert from int to LocalDate
public static final String SERIALIZED_NAME_START_DATE = "startDate";
@SerializedName(SERIALIZED_NAME_START_DATE)
private LocalDate startDate;
...
None known.
In the toDefaultValue(Schema) method of org.openapitools.codegen.languages.AbstractJavaCodegen the default value for a date is returned as a String representation of the date, but should probably be a call to LocalDate.parse or similar.
馃憤 Thanks for opening this issue!
馃彿 I have applied any labels matching special text in your issue.
The team will review the labels and make any necessary changes.
@seantreg thanks for reporting the issue. The correct code should look like the following?
private LocalDate endDate = LocalDate.parse("1900-01-01");
UPDATE: just tested locally to confirm the above compiles without issues.
Most helpful comment
@seantreg thanks for reporting the issue. The correct code should look like the following?
UPDATE: just tested locally to confirm the above compiles without issues.