Openapi-generator: [BUG] typescript-angular package.json missing

[FlorianLudwig]

Bug Report Checklist

• [ ] Have you provided a full/minimal spec to reproduce the issue?
• [ ] Have you validated the input using an OpenAPI validator (example)?
• [x] What's the version of OpenAPI Generator used?
• [x] Have you search for related issues/PRs?
• [x] What's the actual output vs expected output?
• [ ] [Optional] Bounty to sponsor the fix (example)

Description

The typescript-angular generator does have a package.mustache file but no package.json is generated.

openapi-generator version

openapi-generator-cli 5.0.0-SNAPSHOT
  commit : 3f38684
  built  : 2020-06-14T10:20:10Z
  source : https://github.com/openapitools/openapi-generator
  docs   : https://openapi-generator.tech/

OpenAPI declaration file content or url

any

Command line used for generation

generate  -i any_openapi.json -g typescript-angular 

Suggest a fix

One of:

• Remove the package.mustache and references (at least in README)
• Actually

[auto-labeler[bot]]

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

[macjohnny]

the package.json is generated if the configuration property npmName is defined, see
https://github.com/OpenAPITools/openapi-generator/blob/2460cfccfa16c099583c25562efdb2f4a84b1b3e/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/TypeScriptAngularClientCodegen.java#L154-L156

https://github.com/OpenAPITools/openapi-generator/blob/2460cfccfa16c099583c25562efdb2f4a84b1b3e/bin/configs/typescript-angular-with-npm-v8.yaml#L7

https://github.com/OpenAPITools/openapi-generator/blob/master/samples/client/petstore/typescript-angular-v8-provided-in-root/builds/with-npm/package.json

[FlorianLudwig]

@macjohnny the README.md lists to use npm install as first step - with won't work without the package.json. So maybe remove that part of the readme? Or point out that npmName is missing?

[macjohnny]

You are right, The readme could be improved. However, it is recommended to look at the generated code as well