Openapi-generator: NullPointerException when run "validate" with OAS2 spec

[ackintosh]

Description

$ java -jar modules/openapi-generator-cli/target/openapi-generator-cli.jar validate -i modules/openapi-generator/src/test/resources/2_0/petstore-with-fake-endpoints-models-for-testing.yaml
Validating spec file (modules/openapi-generator/src/test/resources/2_0/petstore-with-fake-endpoints-models-for-testing.yaml)
Exception in thread "main" java.lang.NullPointerException
        at java.util.HashSet.<init>(HashSet.java:118)
        at org.openapitools.codegen.cmd.Validate.run(Validate.java:44)
        at org.openapitools.codegen.OpenAPIGenerator.main(OpenAPIGenerator.java:52)

openapi-generator version

Latest master

Suggest a fix/enhancement

It may caused by SwaggerConverter as the converter doesn't set message.

In case of parsing OAS3, OpenAPIDeserializer sets message.

I think that SwaggerConverter should set the message as well.

[ackintosh]

I'll file the PR that fixes the issue to https://github.com/OpenAPITools/swagger-parser

[jmini]

I would appreciate if you could also file an issue in the original swagger-parser project. I am open for discussion and I have opened #68 for that.

[jmini]

This depends from swagger-api/swagger-parser#710

[ackintosh]

I changed my mind, I'll file a PR to the original swagger-parser. 💡

[ackintosh]

(tracking)

• swagger-api/swagger-parser#710 has been merged.
• the release of swagger-parser contains swagger-api/swagger-parser#710 is planned.
  
  
  
  • https://github.com/swagger-api/swagger-parser/issues/717
  
  

[jmini]

With #123 we use swagger-parser version 2.0.1-SNAPSHOT. This should fix this issue.

[ackintosh]

Confirmed this issue is fixed with #123 👍 This issue will be closed after 3.0.0 release.

[jmini]

Anything left to do here? or can we close this issue?

[ackintosh]

Nothing to do for this issue. 🎉