Open-ps2-loader: [ISSUE] OPL isn't recognizing the translation in mc/OPL folder anymore

[hardlevel]

Disclaimer
Issue reports for OPL version which were not downloaded from the official GitHub repo are not accepted.
Before posting the issue confirm that you meet the below requirements.

• [x ] I have checked existing OPL issues for duplicates and found none https://github.com/ps2homebrew/Open-PS2-Loader/issues
• [x ] I am using either OPL beta version from https://github.com/ps2homebrew/open-ps2-loader/actions?query=workflow%3ACI+is%3Asuccess++ or OPL stable version from https://github.com/ps2homebrew/Open-PS2-Loader/releases

Describe the issue
In the newest verions of the betas, OPL stoped to load the translations files in OPL folder on MC

Configuration (please complete the following information):

• Console Model: [e.g. SCPH-77006]: 39001
• Open PS2 Loader revision: [e.g. OPNPS2LD-c5ed52e6, OPL v0.9.3] Newest Beta
• Open PS2 Loader mode: [e.g. USB, SMB, HDD] USB,HDD
• Information about affected games (if any): link to redump.org or game serial: [e.g. http://redump.org/disc/561 or SLES-52798]

To Reproduce
Steps to reproduce the behavior:
Just insert a translation file in OPL folder and try to change it in display settings

Expected behavior
OPL was expected to show the translation file, it only works on LNG folder

[J013k]

I have the same problem.
I have try OPL 1559 & 1562 from here:
https://www.psx-place.com/threads/open-ps2-loader-v0-9-3.13415/page-51#post-255460.

But none of these versions seems to search for a translation on a memory card.
The latest version that loads translation from a memory card is OPL 1555:
https://github.com/ps2homebrew/Open-PS2-Loader/actions/runs/206675471.

Thanks for this test and a bug report.

[KrahJohlito]

This is a strange one indeed.. it seems the first call to checkMC() always results in mcID being -1, an additional call then returns the correct ID which is why themes which is init after lang is not affected.. syncing the mcs twice in the function fixes the problem but I don't get why this is required.
https://github.com/KrahJohlito/Open-PS2-Loader/commit/78ca8d1c1bee87f0b40e9877a2f496724484d80e

@uyjulian any thoughts?

p.s languages in general seem to be broken at the moment judging by all the TLB misses I get in pcsx2 after loading one but in the gcc10 build this does not happen so I think its just the gcc compat changes so once it has been updated that problem should be fixed anyway.

Edit: Think I found it, it’s just because of the return value is -1 the first time but we’re checking for it to be 0 which it is after another call.. I’ll test it tomorrow.
https://github.com/ps2dev/ps2sdk/blob/3c4e3ef0df01c49bdb4620c32d3496eeab5f7f81/ee/rpc/memorycard/samples/mc_example.c#L77