Open-event-server: My Sessions: Server is returning duplicated data
Describe the bug
My Session is showing session's multiple times
Expected behaviour
Server should return session only once
Screenshots
Responses for Reference :
https://github.com/fossasia/open-event-frontend/pull/3811#issuecomment-575883439
https://github.com/fossasia/open-event-frontend/pull/3811#issuecomment-575882180
kushthedude
All 15 comments
cc: @iamareebjamal @mrsaicharan1
kushthedude
on 22 Jan 2020
@kushthedude - Are you working on this?
codedsun
on 22 Jan 2020
You may proceed!
On Wed, 22 Jan, 2020, 19:11 Suneet Srivastava, notifications@github.com
wrote:
@kushthedude https://github.com/kushthedude - Are you working on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/open-event-server/issues/6763?email_source=notifications&email_token=AKQMTLX7DZC4FHRQL4RFWC3Q7BEI5A5CNFSM4KKD36S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJTSXXY#issuecomment-577186783,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKQMTLVXYZRIPAWPUFCHFXDQ7BEI5ANCNFSM4KKD36SQ
.
kushthedude
on 22 Jan 2020
@kushthedude @iamareebjamal - Is their a specific case for sessions to return duplicated data.?
For me, I have a user with two sessions which have been submitted but not accepted. But the api returns correct data.
http://127.0.0.1:5000/v1/users/2/sessions?sort=starts-at
Response:
{
"data": [
{
"type": "session",
"attributes": {
"is-mail-sent": false,
"ends-at": null,
"subtitle": "Helloe",
"comments": "Hi I am admin ediiting it now",
"complex-field-values": null,
"language": "Hindi",
"level": "Hard",
"deleted-at": null,
"audio-url": null,
"is-locked": false,
"last-modified-at": "2020-01-20T13:59:18.881961+00:00",
"average-rating": null,
"short-abstract": "Suneet Srivastava EevtnyayaSuneet Srivastava EevtnyayaSuneet Srivastava Eevtnyaya",
"starts-at": null,
"title": "Suneet Srivastava Eventyay2",
"state": "pending",
"signup-url": null,
"long-abstract": "Suneet Srivastava EevtnyayaSuneet Srivastava EevtnyayaSuneet Srivastava EevtnyayaSuneet Srivastava Eevtnyaya",
"submitted-at": "2019-12-29T19:24:13.010000+00:00",
"slides-url": null,
"video-url": null,
"created-at": "2019-12-29T19:24:13.068583+00:00"
},
"relationships": {
"microlocation": {
"links": {
"self": "/v1/sessions/2/relationships/microlocation",
"related": "/v1/sessions/2/microlocation"
}
},
"track": {
"links": {
"self": "/v1/sessions/2/relationships/track",
"related": "/v1/sessions/2/track"
}
},
"feedbacks": {
"links": {
"self": "/v1/sessions/2/relationships/feedbacks",
"related": "/v1/sessions/2/feedbacks"
}
},
"speakers": {
"links": {
"self": "/v1/sessions/2/relationships/speakers",
"related": "/v1/sessions/2/speakers"
}
},
"session-type": {
"links": {
"self": "/v1/sessions/2/relationships/session-type",
"related": "/v1/sessions/2/session-type"
}
},
"creator": {
"links": {
"self": "/v1/sessions/2/relationships/creator",
"related": "/v1/sessions/2/creator"
}
},
"event": {
"links": {
"self": "/v1/sessions/2/relationships/event",
"related": "/v1/sessions/2/event"
}
}
},
"id": "2",
"links": {
"self": "/v1/sessions/2"
}
},
{
"type": "session",
"attributes": {
"is-mail-sent": false,
"ends-at": null,
"subtitle": null,
"comments": "Synet123123677",
"complex-field-values": null,
"language": null,
"level": null,
"deleted-at": null,
"audio-url": null,
"is-locked": false,
"last-modified-at": "2020-01-20T17:19:01.228848+00:00",
"average-rating": null,
"short-abstract": "Suneet Sassas",
"starts-at": null,
"title": "Suneet Srivastava",
"state": "pending",
"signup-url": null,
"long-abstract": null,
"submitted-at": "2019-12-28T13:09:16.567000+00:00",
"slides-url": null,
"video-url": null,
"created-at": "2019-12-28T13:09:16.653535+00:00"
},
"relationships": {
"microlocation": {
"links": {
"self": "/v1/sessions/1/relationships/microlocation",
"related": "/v1/sessions/1/microlocation"
}
},
"track": {
"links": {
"self": "/v1/sessions/1/relationships/track",
"related": "/v1/sessions/1/track"
}
},
"feedbacks": {
"links": {
"self": "/v1/sessions/1/relationships/feedbacks",
"related": "/v1/sessions/1/feedbacks"
}
},
"speakers": {
"links": {
"self": "/v1/sessions/1/relationships/speakers",
"related": "/v1/sessions/1/speakers"
}
},
"session-type": {
"links": {
"self": "/v1/sessions/1/relationships/session-type",
"related": "/v1/sessions/1/session-type"
}
},
"creator": {
"links": {
"self": "/v1/sessions/1/relationships/creator",
"related": "/v1/sessions/1/creator"
}
},
"event": {
"links": {
"self": "/v1/sessions/1/relationships/event",
"related": "/v1/sessions/1/event"
}
}
},
"id": "1",
"links": {
"self": "/v1/sessions/1"
}
}
],
"links": {
"self": "/v1/users/2/sessions?sort=starts-at"
},
"meta": {
"count": 4
},
"jsonapi": {
"version": "1.0"
}
}
http://127.0.0.1:5000/v1/users/2/sessions?page%5Bsize%5D=10&page%5Bnumber%5D=1&include=event&sort=starts-at
By removing the filter also works fine for me.
codedsun
on 26 Jan 2020
I have given the API Link above it is returning same sessions for page 2
and 3. Same is the case on local
On Sun, 26 Jan, 2020, 20:51 Suneet Srivastava, notifications@github.com
wrote:
>
http://127.0.0.1:5000/v1/users/2/sessions?page%5Bsize%5D=10&page%5Bnumber%5D=1&include=event&sort=starts-at
By removing the filter also works fine for me.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/open-event-server/issues/6763?email_source=notifications&email_token=AKQMTLXLUUFIU6ETPZZSWVLQ7WTAVA5CNFSM4KKD36S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ5WK3Y#issuecomment-578512239,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKQMTLQXEQ2SIFPWZB2FKJTQ7WTAVANCNFSM4KKD36SQ
.
kushthedude
on 26 Jan 2020
@codedsun Because there are not even enough items to do pagination, so obviously it'll return correct data
iamareebjamal
on 26 Jan 2020
Ok will check it out.
On Sun, Jan 26, 2020, 9:06 PM Areeb Jamal notifications@github.com wrote:
@codedsun https://github.com/codedsun Because there are not even enough
items to do pagination, so obviously it'll return correct data—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/open-event-server/issues/6763?email_source=notifications&email_token=AEYZISA355KZMY43FCQI2KDQ7WUW3A5CNFSM4KKD36S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ5WUXA#issuecomment-578513500,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEYZISG23CQGRBC4AIOPBOLQ7WUW3ANCNFSM4KKD36SQ
.
codedsun
on 26 Jan 2020
Since the merged PR has been reverted. Reopening this issue, also please check https://github.com/fossasia/open-event-server/issues/6794 for reason why the PR was reverted .
kushthedude
on 28 Jan 2020
I'll take a look at this.
mrsaicharan1
on 30 Jan 2020
@mrsaicharan1 #6794 was actual solution but it doesn't work with sort parameter, so that needs to be fixed
iamareebjamal
on 30 Jan 2020
@iamareebjamal - If we change the queery to
query_.distinct(Session.id, Session.starts_at).join(User) it will work.
the error occurs because the Order by runs on different field and distinct runs on another one
codedsun
on 31 Jan 2020
Great, send a PR so we can revert it when ?order_by=ends_at crashes. That is not the solution
iamareebjamal
on 31 Jan 2020
@iamareebjamal - Nopes this isn't the right solution. I am looking for more
codedsun
on 31 Jan 2020
Paste the SQL query generated in the statement with and without distinct
iamareebjamal
on 31 Jan 2020
Related issues
mariobehling
·
4Comments
iamareebjamal
·
4Comments
mariobehling
·
4Comments
poush
·
3Comments
rafalkowalski
·
3Comments