Open-event-server: Discount Code Orders possible even though number of discounted tickets exhausted

[mariobehling]

Organizers have the option to limit discount tickets. Even though the number is exhausted users can still get discounted tickets. This should not be possible.

Replicate: Go to event dashboard, click on "Tickets" choose "Discount" on the left sidebar and create a discount code. Use this discount code and try to buy tickets after you ordered the number of max. discount tickets. It will still work.

[kushthedude]

I will take a look at it.

[Rits1272]

Can I work on this issue?

[prateekj117]

Hey @Rits1272, great to see you want to contribute here. This is a high priority issue. You can look into some other issues for now.

@kushthedude Update?

[Rits1272]

Sure @prateekj117.I will look into some other issue.

[prateekj117]

@kushthedude Progress on this?

[kushthedude]

Not much, you may take it up, was occupied with ci and routing issue. You
may take up if you want.

On Thu, 7 Nov, 2019, 10:57 Prateek Jain, [e-mail] wrote:

@kushthedude https://github.com/kushthedude Progress on this?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/open-event-server/issues/6569?email_source=notifications&email_token=AKQMTLUSJQYIHO5VSRI4N6DQSORLPA5CNFSM4JIMO4C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDKICWY#issuecomment-550797659,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKQMTLQRIVMZS7RWV5JNUEDQSORLPANCNFSM4JIMO4CQ
.

[prateekj117]

@mariobehling @iamareebjamal Taking this one up.

[kushthedude]

@prateekj117 Did you get time to debug ?

[prateekj117]

@kushthedude Yup. The logic is kind of complex so I and @iamareebjamal decided to look after these issues directly in the new Orders API.

[kushthedude]

What about the new release than?
If there is any hotfix for this currently @iamareebjamal . As order api may
take some time.

On Sun, 17 Nov, 2019, 23:05 Prateek Jain, [e-mail] wrote:

@kushthedude https://github.com/kushthedude Yup. The logic is kind of
complex so I and @iamareebjamal https://github.com/iamareebjamal
decided to look after these issues directly in the new Orders API.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/open-event-server/issues/6569?email_source=notifications&email_token=AKQMTLUFHM2IUOA75G5JBDTQUF6GBA5CNFSM4JIMO4C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEIROWQ#issuecomment-554768218,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKQMTLVO7GSF5TSECWIQSITQUF6GBANCNFSM4JIMO4CQ
.

[kushthedude]

@iamareebjamal

On Sun, 17 Nov, 2019, 23:22 Kush Trivedi, [e-mail] wrote:

What about the new release than?
If there is any hotfix for this currently @iamareebjamal . As order api
may take some time.

On Sun, 17 Nov, 2019, 23:05 Prateek Jain, [e-mail]
wrote:

@kushthedude https://github.com/kushthedude Yup. The logic is kind of
complex so I and @iamareebjamal https://github.com/iamareebjamal
decided to look after these issues directly in the new Orders API.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/open-event-server/issues/6569?email_source=notifications&email_token=AKQMTLUFHM2IUOA75G5JBDTQUF6GBA5CNFSM4JIMO4C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEIROWQ#issuecomment-554768218,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKQMTLVO7GSF5TSECWIQSITQUF6GBANCNFSM4JIMO4CQ
.

[iamareebjamal]

Yes, once 1-2 PRs are finalized, we'll make a release

[codedsun]

Taking this up 👍

[iamareebjamal]

https://github.com/fossasia/open-event-server/issues/6569#issuecomment-554768218

[kushthedude]

6569 (comment)

Should we still wait for the new API or find a way to fix it for now? @iamareebjamal

[iamareebjamal]

No, take this up