Open-event-server: ICalExporter not working

Created on 7 Oct 2019  路  6Comments  路  Source: fossasia/open-event-server

https://github.com/fossasia/open-event-server/blob/97e94f2ce14d20341253822b5456c93bef590c71/app/api/helpers/ICalExporter.py#L48-L53

There is no email attribute on event object.

Fix the method and write tests

bug good-first-issue hacktoberfest help-wanted
Source
picture iamareebjamal

All 6 comments

@iamareebjamal We have tests for ical exports. Will fix this method.

mrsaicharan1 picture mrsaicharan1 on 8 Oct 2019

Yes, but we don't have tests which fail for this case which is equal to having no tests

iamareebjamal picture iamareebjamal on 8 Oct 2019
👀1

@iamareebjamal What kind of a privacy scenario are we considering here when it comes to using speaker.email ?

mrsaicharan1 picture mrsaicharan1 on 9 Oct 2019

I don't know, maybe it's discussed on the PR in which it was implemented

iamareebjamal picture iamareebjamal on 9 Oct 2019
👍1

@iamareebjamal Based on my limited understanding of this issue, I need to ask how can an email be related to an event? Are we referring to the email of the organizer instead?

roshnet picture roshnet on 14 Oct 2019

Yes, @roshnet, it's supposed to be the email of owner/organizer. But event.email is not a field

iamareebjamal picture iamareebjamal on 14 Oct 2019
Was this page helpful?
0 / 5 - 0 ratings

Related issues

poush picture poush  路  3Comments
CosmicCoder96 picture CosmicCoder96  路  3Comments
mariobehling picture mariobehling  路  4Comments
aviaryan picture aviaryan  路  3Comments
mariobehling picture mariobehling  路  4Comments