Open-event-server: Remove all new features from flask-rest-jsonapi fork

Created on 3 Oct 2019  路  15Comments  路  Source: fossasia/open-event-server

Almost all if not all features added in the fork can be shifted from it to the app and implemented and tested correctly.

The most difficult and still incorrectly implemented feature is soft deletion. Which can be implemented more robustly in this manner -
https://github.com/miguelgrinberg/sqlalchemy-soft-delete/blob/master/app.py

It is a pain to maintain the library and most tests are failing

refactor

All 15 comments

From the Fossasia's fork ?

Yes

The new features you referring to are the commits made by us on it?

Yes

@iamareebjamal We can just switch the branch for this, Currently we are using shubh-amp master which needs to be change to master<, this must be enough I think. Or do we need to use latest Flask-Rest API

@kushthedude What about the changes? We still want those changes.

@iamareebjamal Why was it decided to use our own modified version of flask-rest-jsonapi instead of making desired changes in the app from the beginning?

There are some changes still required in the library but most of them are now implemented in the library itself. Some features implemented in the fork resulted from less research on how to achieve the result

@iamareebjamal Ok, so I will see what features are implemented in shubh-amp master, and open relevant sub-issues. I see we are also 164 commits behind original repo of flask-rest-jsonapi, and 27 commits ahead, what should be our way to go in this case?

Move features one by one from the fork to the app

@prateekj117 Are you checking on it ?

@kushthedude Yup. But it's going to take a lot of time and a lot of help from @iamareebjamal. You can also work on some issues.

@iamareebjamal It would be great if you could open some issues here reflecting the changes made in our fork of flask-rest-jsonapi.

@prateekj117 @iamareebjamal Can i work on this issue,?

@iamareebjamal @prateekj117 Can you tell me the first step like what feature shall be made to the app from the fork. So that we can move forward with this. Thanks

decide schema method

Was this page helpful?
0 / 5 - 0 ratings

Related issues

SaptakS picture SaptakS  路  3Comments

mariobehling picture mariobehling  路  4Comments

mariobehling picture mariobehling  路  4Comments

mariobehling picture mariobehling  路  4Comments

dr0pdb picture dr0pdb  路  4Comments