Open-event-server: Wrong image link gets stored instead of becoming null when image is deleted

[ShridharGoel]

Describe the bug
On deleting profile image, the same image link gets stored in avatarUrl with localhost instead of open-event-api-dev.herokuapp.com.

Expected behavior
Image link should become null.

[shreyanshdwivedi]

Will take a look

[prateekj117]

@shreyanshdwivedi If you haven't spent much time on it, May I take this up?

[shreyanshdwivedi]

@prateekj117 yeah sure. I'm a bit busy with other issues

[prateekj117]

@shreyanshdwivedi @ShridharGoel I tried it in development (herokuapp) instance, making PATCH request to change avatar-url from non-null to null works fine, and returns null.

[prateekj117]

@iamareebjamal

[mrsaicharan1]

@ShridharGoel this will be fixed here https://github.com/fossasia/open-event-frontend/pull/3361

[iamareebjamal]

But that is happening on mobile, so it is server issue. Fixing something in frontend won't fix it in mobile

[mrsaicharan1]

Okay.

On Thu, 8 Aug 2019 at 1:10 PM, Areeb Jamal [e-mail] wrote:

Reopened #6303 https://github.com/fossasia/open-event-server/issues/6303
.

—
You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub
https://github.com/fossasia/open-event-server/issues/6303?email_source=notifications&email_token=AGAHUW3ETEXPRCJ2357CPALQDPEYNA5CNFSM4IJFA7U2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOS6EYPMA#event-2542372784,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGAHUW53CMLKBSE2URIHWYLQDPEYNANCNFSM4IJFA7UQ
.

[CosmicCoder96]

the same image link gets stored in avatarUrl with localhost instead of open-event-api-dev.herokuapp.com.

@ShridharGoel I don't follow? What's the correlation between image link and localhost and heroku?

[iamareebjamal]

Image link is - open-event-api-dev.herokuapp.com/static/haha.jpeg

Becomes localhost/static/haha.jpeg on deleting it

[prateekj117]

@shreyanshdwivedi @ShridharGoel I tried it in development (herokuapp) instance, making PATCH request to change avatar-url from non-null to null works fine, and returns null.

@iamareebjamal

[iamareebjamal]

@ShridharGoel Can you please test again

[ShridharGoel]

Tested again. The issue is still there.

[prateekj117]

@ShridharGoel If possible, can you please share the exact request being sent to the server.

[CosmicCoder96]

@iamareebjamal @ShridharGoel @prateekj117 I can't reproduce it through postman, does it happen only via android? It's strange because, deleting an image is equivalent to changing, the avatar URL from some value to null; the keyword localhost can't magically appear.

@ShridharGoel How exactly are you testing it? If it's not reproducible via postman, then it's not a server issue.

[ShridharGoel]

@CosmicCoder96 After deleting an image, I am setting the avatar-url to null and updating the user. But then on fetching the user details again, the link with localhost is being fetched.

[iamareebjamal]

Try with Postman. If it is not happening with Postman, something is wrong on Android side

[ShridharGoel]

[prateekj117]

@iamareebjamal I am not experiencing it using Postman.

[iamareebjamal]

Try with same payload @prateekj117

[iamareebjamal]

@ShridharGoel Does the same happen in production?

[prateekj117]

@iamareebjamal Tried. Still not happening locally. Though I found something weird. When I am sending this request:

Only avatar_url gets updated, and the data in before_update_object function only has avatar_url in it. Can you please check if something is wrong in the request I am sending, or is it a bug.

[ShridharGoel]

Does the same happen in production?

In production, the image is not getting deleted. Same link is being returned. Tried deleting the image via frontend too, but it did not get deleted.

[ShridharGoel]

In production, the image is not getting deleted. Same link is being returned. Tried deleting the image via frontend too, but it did not get deleted.

@iamareebjamal Should I create a separate issue for this?

[prateekj117]

In production, the image is not getting deleted. Same link is being returned. Tried deleting the image via frontend too, but it did not get deleted.

@ShridharGoel Try again after updating frontend dev branch, it was solved in https://github.com/fossasia/open-event-frontend/pull/3361.

[ShridharGoel]

Try again after updating frontend dev branch, it was solved in fossasia/open-event-frontend#3361.

But it's a server issue because it's there on Android too and can be reproduced via Postman also.

[prateekj117]

@ShridharGoel Yes. That is the case. But the localhost url is wrong anyway, so it should not have displayed the avatar after deletion. So it was happening on frontend due to some different issue I guess.

[ShridharGoel]

@prateekj117 It is displaying the same avatar after deletion only on the production instance. For the dev instance the link is getting changed to the localhost one.

[iamareebjamal]

@prateekj117 Frontend comes nowhere in this issue

[prateekj117]

@iamareebjamal Yes, that's a different issue.

[iamareebjamal]

All images except avatar-url and maybe thumbnail-url are/should be dump only. So, they should not be sent to server,

Nevertheless, sending them should not break the implementation

[iamareebjamal]

@CosmicCoder96 Try uploading the image on https://open-event-fe.netlify.com

All links are localhost

[iamareebjamal]

Deleting is not working as well. On production as well

[iamareebjamal]

I reproduced it the first time I tried. I don't know what you guys were doing. @prateekj117

[prateekj117]

@iamareebjamal I was trying on localhost.

[prateekj117]

@iamareebjamal In case you were able to reproduce it on localhost, can you please share your exact request.

[iamareebjamal]

Issue is on hosted instances