Open-event-server: Fetching featured speakers, accepted sessions, public call for speaker by default

Created on 4 Jun 2019  路  11Comments  路  Source: fossasia/open-event-server

Describe the bug
By default, the server should only return featured speakers, accepted sessions, public speakers call when client-side make GET requests. Currently, it also returns pending sessions or private call for speaker.

Additional context
Discussed in: https://github.com/fossasia/open-event-android/pull/1902 (comment)

bug codeheat

Most helpful comment

Revert the PR then

All 11 comments

Except featured speakers, everything should be done as @anhanh11001 stated

@anhanh11001 I'd like to take this.

@anhanh11001 Which endpoint are you talking about?

@mrsaicharan1 every endpoint which returns sessions or call for speakers

@iamareebjamal Would like to take this up.

@iamareebjamal how would pending and other sessions will be retrieved after this?

@CosmicCoder96 By id. For cases like the one stated by @shreyanshdwivedi on Gitter, we can check the role of retriever and return session list accordingly.

Whar do you mean by id? Id of what? @prateekj117

Only admin and event owner/organizer will be able to see the pending sessions, that too after passing a query parameter, not by default

@prateekj117 To clarify, as of this moment, none of the pages which are not public, work on the frontend, including admin sessions, all, live, past, draft are broken and

Only admin and event owner/organizer will be able to see the pending sessions,

Will implies even server-side refactor was not in the PR? The frontend is completely crippled.

Revert the PR then

Was this page helpful?
0 / 5 - 0 ratings

Related issues

mariobehling picture mariobehling  路  4Comments

schedutron picture schedutron  路  4Comments

poush picture poush  路  3Comments

SaptakS picture SaptakS  路  3Comments

rafalkowalski picture rafalkowalski  路  3Comments