Open-event-server: Delete User Favorite By EventId

[aggarwalpulkit596]

Is your feature request related to a problem? Please describe.
Current Implementation of user-favorite-events allows deletion of events by using the id given by the server.
Describe the solution you'd like
There should be an option to delete the event using eventId rather the user-favorite-event id

[aggarwalpulkit596]

@mrsaicharan1 Can you take a look

[mrsaicharan1]

Yeah! Will solve this.

On Wed, 1 May 2019 at 6:58 PM, Pulkit Aggarwal [e-mail]
wrote:

@mrsaicharan1 https://github.com/mrsaicharan1 Can you take a look

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
https://github.com/fossasia/open-event-server/issues/5857#issuecomment-488282036,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGAHUW5U7YGXZNS2PO2FZYTPTGLIPANCNFSM4HJTPUFA
.

[aggarwalpulkit596]

@mrsaicharan1 any update on this ?

[mrsaicharan1]

@aggarwalpulkit596 Sorry for the delay on this. Will get up to speed with this today.

[mrsaicharan1]

DELETE methods are automatically integrated when JSON API endpoints are created. What is the query you're having a problem with right now? You can directly delete the event using event_id.

[mrsaicharan1]

http://127.0.0.1:5000/#events-event-details-delete

[iamareebjamal]

We're talking about deleting favorite, not the event

[aggarwalpulkit596]

Any Update @mrsaicharan1 on this

[aggarwalpulkit596]

This is a major roadblock for the app we need this ASAP @iamareebjamal correct?

[mrsaicharan1]

There are some priority issues which are blocking the system from
functioning properly right now. I've been involved in the discussions and
the necessary things required for them.
Will try to do this as soon as I'm finished with those. You can keep a tab
on the issue tracker and the gitter channels as to what we've been talking
about :) .However, in the meantime, anyone else is welcome to take this.

On Sun, 19 May 2019 at 4:03 PM, Pulkit Aggarwal [e-mail]
wrote:

Any Update @mrsaicharan1 https://github.com/mrsaicharan1 on this

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
https://github.com/fossasia/open-event-server/issues/5857?email_source=notifications&email_token=AGAHUW5JP6X4GYPLJNMZT5DPWEUHPA5CNFSM4HJTPUFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVW7KTY#issuecomment-493745487,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGAHUWYU5D7LINLCRUSZYJTPWEUHPANCNFSM4HJTPUFA
.

[iamareebjamal]

@prateekj117 Can you take this up?

[prateekj117]

@iamareebjamal Sure. On it. 👍

[prateekj117]

So one solution here is to pass body in the Request, but @iamareebjamal told that Delete method doesn't work with body. So one solution is to make a new endpoint. Or is there any other solution? @uds5501 @mrsaicharan1 @shreyanshdwivedi

[mrsaicharan1]

You'll need to make a new API endpoint using flask_reset_json_api to create
and update this. The delete function will be integrated automatically.

On Mon, 20 May 2019 at 1:00 PM, Prateek Jain [e-mail]
wrote:

So one solution here is to pass body in the Request, but @iamareebjamal
https://github.com/iamareebjamal told that Delete method doesn't work
with body. So one solution is to make a new endpoint. Or is there any other
solution? @uds5501 https://github.com/uds5501 @mrsaicharan1
https://github.com/mrsaicharan1 @shreyanshdwivedi
https://github.com/shreyanshdwivedi

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
https://github.com/fossasia/open-event-server/issues/5857?email_source=notifications&email_token=AGAHUWYWWUFMUZAVMMJSBTLPWLRNJA5CNFSM4HJTPUFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVZTR4A#issuecomment-494090480,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGAHUWZTASTVCMKNZ4W4X6TPWLRNJANCNFSM4HJTPUFA
.

[iamareebjamal]

There'll be no need of create as it won't be different from the previous endpoint and delete function won't be integrated automatically since you're not deleting the resource by its ID. you are deleting it by event's ID

[prateekj117]

@iamareebjamal Without creating a new endpoint, how would we know if the client passed an id or an event_id to delete the favorite.

[iamareebjamal]

You can create a new endpoint, but there'll be no create or update and delete will not be integrated automatically. You'll have to write custom delete function

[prateekj117]

@iamareebjamal So a new endpoint with a custom delete function, so do you have something else in mind?

[iamareebjamal]

No