Open-event-server: relationship with discount code not present with event

Created on 17 Jun 2018 · 7Comments · Source: fossasia/open-event-server

Describe the bug
Relationship with discount-codes, not present in list event endpoint

To Reproduce
Steps to reproduce the behavior:

Hit the endpoint https://open-event-api-dev.herokuapp.com/v1/events
Look at relationships

Expected behavior
It should be present

Source

simarsingh24

All 7 comments

   "relationships": {
                "custom-forms": {
                    "links": {
                        "self": "/v1/events/76/relationships/custom-forms",
                        "related": "/v1/events/76/custom-forms"
                    }
                },
                "event-copyright": {
                    "links": {
                        "self": "/v1/events/76/relationships/event-copyright",
                        "related": "/v1/events/76/event-copyright"
                    }
                },
                "feedbacks": {
                    "links": {
                        "self": "/v1/events/76/relationships/feedbacks",
                        "related": "/v1/events/76/feedbacks"
                    }
                },
                "microlocations": {
                    "links": {
                        "self": "/v1/events/76/relationships/microlocations",
                        "related": "/v1/events/76/microlocations"
                    }
                },
                "tax": {
                    "links": {
                        "self": "/v1/events/76/relationships/tax",
                        "related": "/v1/events/76/tax"
                    }
                },
                "faqs": {
                    "links": {
                        "self": "/v1/events/76/relationships/faqs",
                        "related": "/v1/events/76/faqs"
                    }
                },
                "event-topic": {
                    "links": {
                        "self": "/v1/events/76/relationships/event-topic",
                        "related": "/v1/events/76/event-topic"
                    }
                },
                "speakers": {
                    "links": {
                        "self": "/v1/events/76/relationships/speakers",
                        "related": "/v1/events/76/speakers"
                    }
                },
                "social-links": {
                    "links": {
                        "self": "/v1/events/76/relationships/social-links",
                        "related": "/v1/events/76/social-links"
                    }
                },
                "sponsors": {
                    "links": {
                        "self": "/v1/events/76/relationships/sponsors",
                        "related": "/v1/events/76/sponsors"
                    }
                },
                "speakers-call": {
                    "links": {
                        "self": "/v1/events/76/relationships/speakers-call",
                        "related": "/v1/events/76/speakers-call"
                    }
                },
                "event-type": {
                    "links": {
                        "self": "/v1/events/76/relationships/event-type",
                        "related": "/v1/events/76/event-type"
                    }
                },
                "session-types": {
                    "links": {
                        "self": "/v1/events/76/relationships/session-types",
                        "related": "/v1/events/76/session-types"
                    }
                },
                "tracks": {
                    "links": {
                        "self": "/v1/events/76/relationships/tracks",
                        "related": "/v1/events/76/tracks"
                    }
                },
                "faq-types": {
                    "links": {
                        "self": "/v1/events/76/relationships/faq-types",
                        "related": "/v1/events/76/faq-types"
                    }
                },
                "tickets": {
                    "links": {
                        "self": "/v1/events/76/relationships/tickets",
                        "related": "/v1/events/76/tickets"
                    }
                },
                "ticket-tags": {
                    "links": {
                        "self": "/v1/events/76/relationships/ticket-tags",
                        "related": "/v1/events/76/ticket-tags"
                    }
                },
                "sessions": {
                    "links": {
                        "self": "/v1/events/76/relationships/sessions",
                        "related": "/v1/events/76/sessions"
                    }
                },
                "event-sub-topic": {
                    "links": {
                        "self": "/v1/events/76/relationships/event-sub-topic",
                        "related": "/v1/events/76/event-sub-topic"
                    }
                }
            },

simarsingh24 on 17 Jun 2018

I was right when I said it's not a bug. We don't send relationship with Discount code on the List of Events as
it is not something we want to show to any user.
If you want to get it you'll have to use the Event details or get the list of events under a user.

dr0pdb on 17 Jun 2018

👍1

@srv-twry its not there in event details too
try hitting this
https://open-event-api-dev.herokuapp.com/v1/events/76

 "relationships": {
            "faqs": {
                "links": {
                    "self": "/v1/events/76/relationships/faqs",
                    "related": "/v1/events/76/faqs"
                }
            },
            "ticket-tags": {
                "links": {
                    "self": "/v1/events/76/relationships/ticket-tags",
                    "related": "/v1/events/76/ticket-tags"
                }
            },
            "social-links": {
                "links": {
                    "self": "/v1/events/76/relationships/social-links",
                    "related": "/v1/events/76/social-links"
                }
            },
            "tracks": {
                "links": {
                    "self": "/v1/events/76/relationships/tracks",
                    "related": "/v1/events/76/tracks"
                }
            },
            "event-type": {
                "links": {
                    "self": "/v1/events/76/relationships/event-type",
                    "related": "/v1/events/76/event-type"
                }
            },
            "tax": {
                "links": {
                    "self": "/v1/events/76/relationships/tax",
                    "related": "/v1/events/76/tax"
                }
            },
            "faq-types": {
                "links": {
                    "self": "/v1/events/76/relationships/faq-types",
                    "related": "/v1/events/76/faq-types"
                }
            },
            "custom-forms": {
                "links": {
                    "self": "/v1/events/76/relationships/custom-forms",
                    "related": "/v1/events/76/custom-forms"
                }
            },
            "speakers-call": {
                "links": {
                    "self": "/v1/events/76/relationships/speakers-call",
                    "related": "/v1/events/76/speakers-call"
                }
            },
            "tickets": {
                "links": {
                    "self": "/v1/events/76/relationships/tickets",
                    "related": "/v1/events/76/tickets"
                }
            },
            "sessions": {
                "links": {
                    "self": "/v1/events/76/relationships/sessions",
                    "related": "/v1/events/76/sessions"
                }
            },
            "event-topic": {
                "links": {
                    "self": "/v1/events/76/relationships/event-topic",
                    "related": "/v1/events/76/event-topic"
                }
            },
            "event-sub-topic": {
                "links": {
                    "self": "/v1/events/76/relationships/event-sub-topic",
                    "related": "/v1/events/76/event-sub-topic"
                }
            },
            "session-types": {
                "links": {
                    "self": "/v1/events/76/relationships/session-types",
                    "related": "/v1/events/76/session-types"
                }
            },
            "event-copyright": {
                "links": {
                    "self": "/v1/events/76/relationships/event-copyright",
                    "related": "/v1/events/76/event-copyright"
                }
            },
            "feedbacks": {
                "links": {
                    "self": "/v1/events/76/relationships/feedbacks",
                    "related": "/v1/events/76/feedbacks"
                }
            },
            "speakers": {
                "links": {
                    "self": "/v1/events/76/relationships/speakers",
                    "related": "/v1/events/76/speakers"
                }
            },
            "sponsors": {
                "links": {
                    "self": "/v1/events/76/relationships/sponsors",
                    "related": "/v1/events/76/sponsors"
                }
            },
            "microlocations": {
                "links": {
                    "self": "/v1/events/76/relationships/microlocations",
                    "related": "/v1/events/76/microlocations"
                }
            }

simarsingh24 on 17 Jun 2018

also if you look at http://open-event-api.herokuapp.com/#events-event-details-get
you will see event detials relationship even in the event list endpoint

"discount-codes": {
          "links": {
            "self": "/v1/events/1/relationships/discount-codes",
            "related": "/v1/events/1/discount-codes"
          }
        }
      },

simarsingh24 on 17 Jun 2018

Relationships like "stripe-authorization" are also not in this. Are you the organizer of the event. If yes, then the server will send you the relationship with the discount code otherwise it won't.
We cannot send sensitive information like "stripe-authorization" or the "discount-code" etc. to any user. the user should either be the admin or the event organizer.
Try creating an event with your own user account and then check. the discount code relationship will be there.

dr0pdb on 17 Jun 2018

👍1

But a registered user should be able to view discount codes, I have already implemented discount code viewing in open event droidgen in which user can login to view discount codes under an event.
The problem here at open event android is that we are trying to store is with relation to event, which we are not getting from api response

simarsingh24 on 17 Jun 2018

But a registered user should be able to view discount codes

Definitely not. If we show any registered user the discount code, then it would defeat the purpose of it being a code. It's a coupon, if you start giving everyone the coupon then what's the point of it.