Open-event-server: Notification response needs further details for FE regarding actions

[CosmicCoder96]

Is your feature request related to a problem? Please describe.

Current action data is notification response is not enough.

Describe the solution you'd like

The response should be something like this,

{
    "title": "New session proposal for abc",
    "message": "abc event",
    "actions": [
      {
        "type": "view",
        "subject": "session",
        "id": 1324
      },
      {
        "type": "delete",
        "subject": "session",
        "id": 1324
      }
    ],
    "is-read": false,
    "received-at": "2018-05-19T18:13:43.500342+00:00"
}

Where actions is an array contain all the actions a user should be able to perform in the order of priority. (i.e. the first action element of the array is to be considered the primary action and so on - FE should display/behave accordingly.)

[schedutron]

Working on it.

[bhavybarca]

@schedutron can i work on it with you ?

[schedutron]

@bhavybarca sure, but how should we split this up?

[schedutron]

Currently, action is a string column in the notification database model. To implement a list of actions, there should be a separate actions table with a one-to-many relationship between notifications and actions? Thoughts @iamareebjamal @bhaveshAn @srv-twry @mayank8318?

[dr0pdb]

Why not a comma separated value ? @schedutron

[schedutron]

@srv-twry Something like "type, subject, id, view, session, 1324, delete, session, 1324"?

[schedutron]

Will the above format work?

[dr0pdb]

@schedutron Sorry about the delay. Saw it just now. I think a separate table should be used here. Ignore my previous suggestion.

[dr0pdb]

@niranjan94 @CosmicCoder96
Need your help. I noticed this just now.
The response for a new session proposal from server is something like this:

NEW_SESSION: {
        'title': u'New session proposal for {event_name}',
        'message': u"The event <strong>{event_name}</strong> has received" +
                   u"a new session proposal.<br><br>" +
                   u"<a href='{link}' class='btn btn-info btn-sm'>View Session</a>",
        'recipient': 'Organizer',
    },

It already has the link added in the button. Similarly proper links are already added in the buttons for other notifications also. I don't see the point of adding actions. The FE can simply render this in the frontend and add some styling and it should automatically work.

[CosmicCoder96]

@srv-twry
Yes, the server returns a full HTML button in the actions. But that really shouldn’t be the way. Server is meant to be consumed ny more than just frontend and even the frontend’s html May change over time. Rather the server should return the concrete data of the actions which are possible with a notification. The frontend can use the actions array to generate appropriate buttons.

[iamareebjamal]

@CosmicCoder96 Agreed. This was also my concern over sending event description as HTML