Open-event-server: Return the user to the same tab in all pages that contain tabs.

Created on 22 Dec 2016  路  13Comments  路  Source: fossasia/open-event-server

After performing any actions like delete return the user to the same tab instead of taking him/her to the first tab.

Has to be done in the following pages

  • [ ] - /admin/events/
  • [ ] - /admin/sessions/
  • [ ] - /admin/users/
  • [ ] - /admin/permissions/
  • [ ] - /admin/settings/
  • [ ] - /events/
  • [ ] - /mytickets/
  • [ ] - /events/mysessions/

It has already been done in

  • [x] - /admin/reports/
  • [x] - /admin/content/
bug
Source
picture niranjan94
👍1

All 13 comments

@SaptakS issue description has been updated

niranjan94 picture niranjan94 on 22 Dec 2016

@niranjan94 noticed. :+1:

SaptakS picture SaptakS on 22 Dec 2016

I have tested this by deleting the events ,sessions ,users in
-/admin/events/

  • /admin/sessions/
  • /admin/users/

    • /admin/permissions/

  • /admin/settings/
    looks like everything works fine
    @niranjan94 @SaptakS
nikhilrayaprolu picture nikhilrayaprolu on 23 Dec 2016

@nikhilrayaprolu everything 'works' fine ... But not very user-friendly is it :wink: .. Each time the user has to go back to the tab he was on before ...

niranjan94 picture niranjan94 on 23 Dec 2016

but at these addresses
-/admin/settings/
-/events/
It is getting redirect to the same url but to different tab(for instance if we delete a drafted event , it is being redirected to live events tab ,since we dont have a specific url assigned for each tab .
One way we could do this is to implement url query parameters for each tab and read the query parameter by parsing the url each time

nikhilrayaprolu picture nikhilrayaprolu on 23 Dec 2016

Correct ... But no need to make it too complex by have query params and passing them. See how it has been implemented in

  • /admin/reports/
  • /admin/content/
niranjan94 picture niranjan94 on 23 Dec 2016

@niranjan94 a href to '#tab-name' is used in those pages. So how were you informing the browser to that tab in a response from backend(views) ?

nikhilrayaprolu picture nikhilrayaprolu on 24 Dec 2016

@nikhilrayaprolu the backend we just gave a redirect to the user's previous page URL ...

niranjan94 picture niranjan94 on 25 Dec 2016

@niranjan94 can you please point out the line number in views where you have explicitly used this functionality.

nikhilrayaprolu picture nikhilrayaprolu on 25 Dec 2016

@SaptakS Can I work on this issue ?

shubham-padia picture shubham-padia on 27 Dec 2016

@nikhilrayaprolu there is no specific point. It is just like any other page. The user is sent back to the previous url.

niranjan94 picture niranjan94 on 27 Dec 2016

@shubham-padia I think @nikhilrayaprolu is working in it.

SaptakS picture SaptakS on 27 Dec 2016
👍1

@shubham-padia you can proceed with this issue. I am working on another issue right now.

nikhilrayaprolu picture nikhilrayaprolu on 27 Dec 2016
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

rafalkowalski picture rafalkowalski  路  3Comments
CosmicCoder96 picture CosmicCoder96  路  3Comments
Masquerade0097 picture Masquerade0097  路  3Comments
mariobehling picture mariobehling  路  4Comments
CosmicCoder96 picture CosmicCoder96  路  4Comments