Open-event-frontend: Improvements in Add New Custom Form Widget

Created on 3 Nov 2019  路  8Comments  路  Source: fossasia/open-event-frontend

Describe the bug
Add Custom Field Widget needs some improvements:

  • Add another Custom Field Button Available even when Session and Speakers are
    turned off.
  • When clicked, there is no way to delete the row/field if someone doesn't
    want to add a custom field. And when sessions and speakers are enabled, and
    someone clicked the Add Custom Field button, but don't want to submit a
    custom field, the system does not Save Draft or Publish an event and
    throws an error that Field cannot be null, which again makes it important
    to maybe have a simple button to add/cancel a field.
  • true printed above every custom field row widget.
  • Make form field as a dropdown with three options:

    • Session

    • Speaker

    • Attendee

To Reproduce
Steps to reproduce the behaviour:

  1. Create an event.
  2. Go to Sessions and Speakers Step.
  3. Test the Custom Fields button for the above-mentioned bugs.

Expected behaviour
Add Custom Field widget should work properly.

Screenshots
Screenshot from 2019-11-04 03-57-08

Additional context
Up for grabs.

bug enhancement ui

Most helpful comment

And the same approach should be followed in future. Hidden in prod and visible in dev until completely tested and ready

All 8 comments

@prateekj117 Except for the UI enhancements, Is the custom form feature working as expected?

@kushthedude Not sure. Will test that. Add urgent as well as we are planning for the next release soon. We should atleast solve the display of true before the release.

Ohh, custom widget will be released in next release too 馃槱

Not sure. @iamareebjamal Need your insight. I was thinking to atleast solve the obvious errors before the release.

Not sure. @iamareebjamal Need your insight. I was thinking to atleast solve the obvious errors before the release.

We cant make next release until its properly tested or another idea is to comment the widget for now just for this release and make it usable until next release.
@iamareebjamal ?

Hide it for now

And the same approach should be followed in future. Hidden in prod and visible in dev until completely tested and ready

The old component was too complicated and a new simpler component is now used.

Was this page helpful?
0 / 5 - 0 ratings