Open-event-frontend: Admin: Add option to add/edit Google map keys/secret

[mariobehling]

The admin settings page currently does not have an option to add or change the map keys. Please add this option here: https://eventyay.com/admin/settings

[kushthedude]

On it

[kushthedude]

@CosmicCoder96 Please transfer it to Server.

[CosmicCoder96]

@kushthedude why transfer? This will certainly require changes on FE too.
Create a new issue on server ?

On Tue, 27 Aug 2019 at 2:37 PM, Kush Trivedi [e-mail]
wrote:

@CosmicCoder96 https://github.com/CosmicCoder96 Please transfer it to
Server.

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
https://github.com/fossasia/open-event-frontend/issues/3484?email_source=notifications&email_token=AEDUDRMVV47PPO5QZKMMDKTQGVX6LA5CNFSM4IQE77V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5IWZLY#issuecomment-525429935,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEDUDRNEIGNMLVMUMZPI7M3QGVX6LANCNFSM4IQE77VQ
.

[mariobehling]

This is also a potential security risk as someone else could be able to get the key. This key needs to be implemented on the server side. Could you open an issue, please?

[iamareebjamal]

Frontend Google Map keys will always be accessible to the client. They are completely secure to be included in frontend. In fact, the JS library of Google Maps requires accessing the key to download JavaScript. Instead, the Google Map API key should be restricted to eventyay.com to secure it using GCP console.

[kushthedude]

Map

@iamareebjamal Currently, keys are retrieved from .env, We would need a field in the server at least to store them.

[iamareebjamal]

And how are you going to use them in frontend to load the Maps SDK?

[iamareebjamal]

And once it is loaded on frontend, anyone can see it. So there's no security aspect here. Just the convenience to be able to change the key, which will require changes on how to load the Map SDK on frontend. Please detail how will you do it?

[CosmicCoder96]

Obsolete now as we are shifting away from Google Maps