Open-event-frontend: Events: events/list & events/view render the same view

[dilpreetsio]

I'm submitting a ... (check one with "x")

• [x] bug report
• [ ] feature request
• [ ] support request => Please do not submit support requests here, instead ask your query in out Gitter channel at https://gitter.im/fossasia/open-event-frontend

Current behaviour
Currently the events/view & events/list render the same view, i.e events/list. This is happening due to the using multiple dynamic routing.

this.route('events', function() {
  this.route('view', { path: '/:event_id' }, function() {
    ...
  }
  this.route('list', { path: '/:event_state' });
  }

Steps to reproduce

• Open https://open-event-frontend.herokuapp.com/events/live & https://open-event-frontend.herokuapp.com/events/963d3ba5

Both the routes load the same template.

@niranjan94 Please guide

[niranjan94]

Yes. This. I faced a similar problem in another project. lemme first see if that fix could work here too.

[niranjan94]

@geekyd works beautifully :)

  beforeModel(transition) {
    const eventState = transition.params[transition.targetName].event_state;
    if (!['live', 'draft', 'past'].includes(eventState)) {
      this.replaceWith('events.view', eventState);
    }
  },

In routes/events/list.js solves it.

[niranjan94]

But for this to work, this.route('list', { path: '/:event_state' }); should be after the events.view definition in router.js. That's how ember router resolves routes.

[dilpreetsio]

Okay I will test this locally & send a PR for this. Thanks :)