Open-event-droidgen: Improve the "No upcoming session dialog" UI

Created on 31 Dec 2017  路  5Comments  路  Source: fossasia/open-event-droidgen

Actual Behaviour

The UI for the "No upcoming session dialog" needs improvement.

Expected Behaviour

The dialog UI should be improved.

Steps to reproduce it

Open LocationsActivity -> Click on any location -> click on upcoming locations icon on the toolbar -> If there is no upcoming session, then the dialog will pop up

Screenshots of the issue

screenshot_2017-12-31-11-55-43-38

Would you like to work on the issue?

Yes

Proposed changes

Using an alert dialog with a single positive button would be more consistent with the Android design principles.

@iamareebjamal @the-dagger Views ?

has-PR
Source
picture dr0pdb

All 5 comments

I would like to work on this issue. May I?
@srv-twry

SparshWadhwa picture SparshWadhwa on 3 Jan 2018

@SparshWadhwa I suggest you wait since the maintainers are probably busy. Once they get time, they will approve this issue first, whether it is worth it or not. Then you can go ahead with it.

dr0pdb picture dr0pdb on 4 Jan 2018
👍1

This screenshot is of current UI or proposed one?

iamareebjamal picture iamareebjamal on 5 Jan 2018

Current UI

dr0pdb picture dr0pdb on 5 Jan 2018
👍1

Yup. Please go ahead and use standard layout

iamareebjamal picture iamareebjamal on 5 Jan 2018
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

iamareebjamal picture iamareebjamal  路  7Comments
mananwason picture mananwason  路  9Comments
shreyasnbhat picture shreyasnbhat  路  8Comments
harshitagupta30 picture harshitagupta30  路  8Comments
mariobehling picture mariobehling  路  8Comments