Open-event-droidgen: Create ViewModel for the DayScheduleFragment

Created on 21 Dec 2017 · 9Comments · Source: fossasia/open-event-droidgen

Actual Behaviour

There is no ViewModel for the DayScheduleFragment

Expected Behaviour

There should be one.

Steps to reproduce it

LogCat for the issue

Screenshots of the issue

Would you like to work on the issue?

Yes!

Target Milestone to solve the issue

Other information

Parent issue #2015

has-PR

Source

dr0pdb

All 9 comments

@srv-twry Can I work on this issue?

codedsun on 30 Dec 2017

@codedsun Please go ahead :)

dr0pdb on 30 Dec 2017

@codedsun Are you still working on the issue?

samagra14 on 23 Jan 2018

@samagra14 I think it has been way too long without any updates. Please go ahead and finish this off. We have a lot of pending work and we should finish creating the ViewModel quickly so that we can move to the next step.

dr0pdb on 23 Jan 2018

@srv-twry I have started working on this issue. I will submit a PR positively by tomorrow.

samagra14 on 23 Jan 2018

👍1

@srv-twry I found that the code is very poorly documented. There are no exclusive comments for methods as such and to get an idea of any method, we have to look at its implementation. I hope work should be done in that direction also as it will get difficult as the size grows. Please let me know your views on this.

samagra14 on 23 Jan 2018

@samagra14 Please create a new issue for it and we can discuss it there. This isn't the best place for it.

dr0pdb on 23 Jan 2018

👍1

@srv-twry I have opened a PR. Please take a look.

samagra14 on 24 Jan 2018

Hi, I would like to try working on this issue, will reference other ViewModels too. Can start tomorrow :)