Open-event-droidgen: Lack of error logs @droidgen.eventyay

Created on 12 May 2017  路  7Comments  路  Source: fossasia/open-event-droidgen

Actual Behaviour
Currently, the generator doesn't provide some sort of logs or proper error messages in case of an error in apk generation.

Expected Behaviour
Whenever there is some error in generating apk, the generator should give proper error messages and logs, if possible so as to enable the developer to do debugging.

Screenshots of the issue
screen shot 2017-05-12 at 10 24 34 am

Would you like to work on the issue?
I am not sure how this works. It will be better for someone more experienced to work on this.

Most helpful comment

@Shailesh351 not exactly. That commit just displays errors in the console. It is still not displayed to the user. So, this issue is for that.

All 7 comments

Instead of just showing error has occurred, first approach should be to at least show at which step it failed. This can be done simply by storing the latest status message and displaying in error the step at which the generation failed.

Currently there is no error handling in generator and adding try catch at each step is unfeasible. What approach should be there @niranjan94

@iamareebjamal

Celery already has error handling capabilities. Two steps to get the error response in the json status request that is used to update the UI.

  • Remove throws=(Exception,) parameter from app/tasks/__init__.py:L6
  • In app/views/api.py change return jsonify(state=state) to return jsonify(state=state, info=str(info))

Now you will get the actual error message as the json parameter info in the status check request

This is very basic. More advance stuff like auto task retry based on error, etc can be done. Do check out the celery documentation @ http://docs.celeryproject.org/en/latest/index.html

@mahikaw , @niranjan94 has fixed it in 9bdec4

@Shailesh351 not exactly. That commit just displays errors in the console. It is still not displayed to the user. So, this issue is for that.

@Shailesh351 that is different. This issue is about error logs on the app generator @droidgen.eventyay

Being addressed in #1798 so closing it

Was this page helpful?
0 / 5 - 0 ratings

Related issues

PareshMayani picture PareshMayani  路  5Comments

Shailesh351 picture Shailesh351  路  6Comments

97k picture 97k  路  5Comments

harshitagupta30 picture harshitagupta30  路  8Comments

dreadpool2 picture dreadpool2  路  7Comments