Open-event-droidgen: DayScheduleFragment leaked 109 KB

[arp95]

Actual Behaviour

After using the app for a while i get a notification as seen below for the information leakage.

Expected Behaviour

Adding appropriate permissions in the manifest file to avoid that.

Steps to reproduce it

1. Use the app for several minutes.
2. While doing so go to different items like tracks, location, schedule etc.
3. You will get a notification of information leaked.

LogCat for the issue

-

Screenshots of the issue

Would you like to work on the issue?

Yes

[iamareebjamal]

@arp95 This is the message from LeakCanary. Once you click on the notification, it'll ask for the permission to access storage once and after that you can see the leaks in the app called Leaks on your device. This was working as expected on Nougat when I last tested. Is your app behaving differently than expected?

[arp95]

@iamareebjamal
actually i tried to open the app different times but after a while i get that leak notifcation.
In the Android Monitor it shows we have to add permission for writing external storage.

[iamareebjamal]

It is just a warning because the library manifest declares that permission and the app doesn't.

We should not add that permission in production code because leak canary won't be shipped in release builds and it will add an unnecessary permission to our app.

I recommend you to wait for another leak or make it happen temporarily and it will be shown just fine. If not, we can look into it

[Shailesh351]

I have also observed same notification and observed that the leak is
because of DayScheduleFragment instance

On Sat, May 6, 2017, 5:36 PM Areeb Jamal [e-mail] wrote:

It is just a warning because the library manifest declares that permission
and the app doesn't.

We should not add that permission in production code because leak canary
won't be shipped in release builds and it will add an unnecessary
permission to our app.

I recommend you to wait for another leak or make it happen temporarily and
it will be shown just fine. If not, we can look into it

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/open-event-android/issues/1489#issuecomment-299635577,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARaybJwiT7C6O6PWibR2kUZ25dIvPJYHks5r3GJbgaJpZM4NSqJP
.

[iamareebjamal]

True. I removed the SwipeRefreshListener in onDestroyView but it is still leaking somewhere. Fixing that issue will non conventionally fix this issue as well @arp95

[arp95]

@iamareebjamal
are you facing this issue?

[Shailesh351]

Screen shot for the same :

[iamareebjamal]

The issue is not about the permission, but the memory being leaked which is being reported by leak canary

Details can be seen when you open the notification

Try to remain at schedule fragment for a period of time, it should show up

[arp95]

@iamareebjamal
yeah was getting this. although the solution might not be as you said will have to look up on the android monitor for further details

[iamareebjamal]

The solution to the leak or permission problem?

[arp95]

what i meant is you might be right permission might not be a solution for this.

[arp95]

resolved the issue. working fine on my device.
submitting the pr in a while.
Thanks for help @iamareebjamal !

[iamareebjamal]

Great!