Open-event-droidgen: Center Alignment of the Speaker photo and Name in details about the event

Created on 6 May 2017  Â·  9Comments  Â·  Source: fossasia/open-event-droidgen

Actual Behaviour

Photo and name of the speaker is aligned to the left of the screen in details about the event.
image

Expected Behaviour
It should be aligned in the centre of the screen.

Would you like to work on the issue?
Yes

Most helpful comment

I tried setting layout_gravity="center" in the recyclerview and this is how it looks:
image
image

Maybe this looks nice? @the-dagger

All 9 comments

@mayank8318 It is not aligned to the left. It is actually a horizontal RecyclerView which shows the list of speakers

Thanks :smile:

@iamareebjamal wouldn't it look better if the image is in the center?

Thanks☺

What will be the case when there are more people?

Nevertheless, centering the image will require recyclerview width to be set to wrap_content, which won't work IMO.

But it is nice if it does. Let's wait for what mentors suggest

@iamareebjamal currently all the events have only one speaker and to handle multiple speakers the entire block of details and the photo can be horizontal scrollable.
What do you think?

It's not true that there are only one speaker per session.

Take Keynote : Deimer event in BlockChain for instance

And multiple speakers are already handled via the current recyclerview. Details don't need to be horizontally scrollable because each event only has one.

@iamareebjamal Right :+1:

@mayank8318
Thanks but this is not really needed atm though.
I'll close this for now.

I tried setting layout_gravity="center" in the recyclerview and this is how it looks:
image
image

Maybe this looks nice? @the-dagger

LGTM @mayank8318
Please send a PR

Was this page helpful?
0 / 5 - 0 ratings

Related issues

iamareebjamal picture iamareebjamal  Â·  8Comments

PareshMayani picture PareshMayani  Â·  5Comments

gogeta95 picture gogeta95  Â·  7Comments

iamareebjamal picture iamareebjamal  Â·  7Comments

mayank8318 picture mayank8318  Â·  4Comments