Open-event-droidgen: Menu icons disappearing, re-appear and disappear again

[mariobehling]

The menu icons have a strange behavior at times and disappear, sometimes re-appear and disappear again.

[arp95]

@mariobehling
can i work on this?

[iamareebjamal]

@arp95 I think the issue is with 4.4 Kitkat, this should minimise the fixing time

[arp95]

@iamareebjamal
sure!
will look into this.

[arp95]

referencing the stackoverflow link here: http://stackoverflow.com/questions/36445507/action-bar-icons-disappear-when-the-drawer-is-opened

main issue for this to happen is the invalidateOptionsMenu() being called in onDrawerOpened() and onDrawerClosed() functions. This should resolve the issue.

[m-murad]

@arp95 @iamareebjamal
Are you able to reproduce the bug? Its working fine on my device.

[iamareebjamal]

Are you using Kitkat?

It is working fine on 5.0+

[arp95]

@free4murad actually i faced this error quite a while back. right now its working fine.
as @iamareebjamal pointed the reason has to be older versions.

[m-murad]

using
Android 4.3
Android 6.0

Working fine for me.

[arp95]

found possible reasons for disappearence of menu icons, and i think its due the menu.clear() statement in onCreateOptionsMenu(). i think we have to use a inflator there for inflating the menu.

[m-murad]

@mariobehling
can you please confirm your device and android version?

[iamareebjamal]

Nevertheless, the fix should be merged so it doesn't happen again. Bugs in support libraries are hard to reproduce and track as we don't know when and how they happen.

I'll try to look for more causes and until then you can add this fix in the PR as well @arp95 :+1: :smiley:

@free4murad He is using 4.4 as inferred from the status bar icons

[harshitagupta30]

It's working fine for me too.

On Sat, May 6, 2017 at 2:04 AM, Arpit Aggarwal [e-mail]
wrote:

found possible reasons for disappearence of menu icons, and i think its
due the menu.clear() statement in onCreateOptionsMenu(). i think we have to
use a inflator there for inflating the menu.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/open-event-android/issues/1446#issuecomment-299569025,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMHNbCVGikCHU6JvIXly1ecKJerJHC3Mks5r24fRgaJpZM4NMjuG
.

[arp95]

@free4murad @iamareebjamal
do update me if you get this bug.
none the less sending the fix for this in the pr.

[m-murad]

I am not debating if we should merge the fix or not. Merging a good option.

Just curious if anyone else is facing the same issue.

Also if we could get the development environment of the people experiencing the bug that would be great.

[arp95]

@free4murad @iamareebjamal
i think go through this link: http://stackoverflow.com/questions/19750635/icon-in-menu-not-showing-in-android

this is what we are looking for.