We defined Turbine:
_A turbine is an energy converting device that converts energy from a moving fluid flow into rotational energy._
But the WindTurbine is currently defined as:
_A wind turbine is a device that converts the wind's kinetic energy into electrical energy._
This definition of WindTurbine currently describes more, what a WindEnergyConvertingUnit.
Current definition of GasTurbine:
_A gas turbine, also called a combustion turbine, is a type of continuous combustion, internal combustion engine._
HydrogenTurbine:
_A hydrogen turbine is a turbine fueled with liquid hydrogen._
SteamTurbine:
_A steam turbine is a device that extracts thermal energy from pressurized steam and uses it to do mechanical work on a rotating output shaft._
WaterTurbine:
_A water turbine is a rotary machine that converts kinetic energy and potential energy of water into mechanical work._
Update all subclass definition. Example for a new WindTurbine definition:
_A wind turbine is a device that converts the wind's kinetic energy into rotational energy._
I am aware that
Absolutely. The new def sounds good.
We could also think about renaming the class to e.g. wind rotor to avoid confusion with the very ambigous term wind tubine.
The defs of the other turbine subclasses could be refined aswell...
The defs of the other turbine subclasses could be refined aswell...
You are right, I adapted the issue that it covers all.
Proposals:
GasTurbine: _A gas turbine is a turbine that converts chemical energy into rotational energy using a continous internal combustion process. Hence it is also called combustion turbine._HydrogenTurbine: _A hydrogen turbine is a gas turbine fueled with hydrogen._SteamTurbine: _A steam turbine is a turbine that converts heat from pressurized steam into rotational energy._WaterTurbine: _A water turbine is a turbine converting kinetic energy and potential energy of water into rotational energy._WindRotor: _A wind rotor (or wind turbine) is a turbine that converts the wind's kinetic energy into rotational energy._In theory we do not need the part _into rotational energy_ for all of the turbine subclasses as already the parent class has it. But for clarity I would include it in all these subclass definitions.
We could also think about renaming the class to e.g.
wind rotorto avoid confusion with the very ambigous termwind tubine.
Your idea is actually very good. If we use WindRotor as primary label we could use WindTurbine as secondary label for both WindRotor and WindEnergyConverter. This then shows that the term WindTurbine is ambiguous.
Most helpful comment
Proposals:
GasTurbine: _A gas turbine is a turbine that converts chemical energy into rotational energy using a continous internal combustion process. Hence it is also called combustion turbine._HydrogenTurbine: _A hydrogen turbine is a gas turbine fueled with hydrogen._SteamTurbine: _A steam turbine is a turbine that converts heat from pressurized steam into rotational energy._WaterTurbine: _A water turbine is a turbine converting kinetic energy and potential energy of water into rotational energy._WindRotor: _A wind rotor (or wind turbine) is a turbine that converts the wind's kinetic energy into rotational energy._In theory we do not need the part _into rotational energy_ for all of the turbine subclasses as already the parent class has it. But for clarity I would include it in all these subclass definitions.
Your idea is actually very good. If we use
WindRotoras primary label we could useWindTurbineas secondary label for bothWindRotorandWindEnergyConverter. This then shows that the termWindTurbineis ambiguous.