HydroPowerPlant and OceanPowerPlant need a rework
Andy HdyroPower and Hydroelectricity also need another glance
So I propose:
with definitions:
HydroPowerplant: A HydroPowerplant is an ArtificialObject that is a powerplant using hydropower as its source of energy.
OceanPowerplant: An OceanPowerplant is a HydroPowerplant that is a powerplant using the oceans motion to create electric energy.
ReservoirPowerplant: A ReservoirPowerplant is a HydroPowerplant that uses one or more reservoirs.
StorageHydroPowerplant: A StorageHydroPowerplant is a Powerplant that stores energy in the form of hydro power.
PumpstoragePowerplant: A PumpstoragePowerplant is a StorageHydroPowerplant used to store energy by pumping water from one reservoir to another.
PumpstoragePowerplantWithNaturalInflux: A PumpstoragePowerplantWithNaturalInflux is a StorageHydroPowerplant that works like a PumpstoragePowerplant but has additional natural influx of water to some of the involved reservoirs.
ReservoirPowerplant: A ReservoirPowerplant is a HydroPowerplant that uses one or more reservoirs.
StorageHydroPowerplant: A StorageHydroPowerplant is a Powerplant that stores energy in the form of hydro power.
Those two definitions are too similar.
PumpstoragePowerplantWithNaturalInflux should be a subclass of PumpstoragePowerplant as every PumpstoragePowerplantWithNaturalInflux is still a PumpstoragePowerplant.
Additionally:
StorageHydroPowerplant: A StorageHydroPowerplant is a Powerplant that stores energy in the form of hydro power.
Alternative prosal: A StorageHydroPowerplant is a Powerplant that stores energy in the form of potential energy of water in a reservoir.
delete the classes for now
From today's OEO dev meeting 17:
New classes:
hydro power generating unit: _A hydro power generating unit is a power generating unit that uses hydro energy._ (analogous to wind)has_part some water turbinehydro power plant: _A hydro power plant is a power plant having an aggregate of hydro power generating units as its power generating units parts._'participates in' some 'hydroelectric energy transformation'run of river power plant: _A run of river power plant is a hydro power plant that uses the momentarily available hydro energy of a river._ (turbine + dam + river)hydro storage power plant: _A hydro storage power plant is a hydro power plant that uses the available hydro energy of a stationary water storage._ (turbine + dam + reservoir)storage power plant (turbine + dam + river)pumped hydro storage power plant: _A pumped hydro storage power plant is a hydro storage power plant which has some pumps._Delete classes as it is basically the same process, only the power plants differ:
hydroelectric dam energy transformationrun-off-river energy transformationMinor things:
Open:
run of river power plant and hydro storage power plant. For the moment, add editorial note on run of river power plant and hydro storage power plant: distinction is important for modelling, but in reality not so easyriver.pumppumped hydro storage power planthydro energy: maybe put 'potential' before 'kinetic' in definition as potential energy has even in run-off river power plants more impact than kinetic energyGeneral:
Regarding the distinction between run of river power plants and hydro storage power plant and the distinction between pumped hydro storage power plants with and without natural intake. Via Wikipedia I found the following ENTSO-E definitions with a special focus on modelling:
a) Run-of-River and Pondage: Plants that do not have pumping capacity, do not have reservoirs, or have small reservoirs with a maximum of 24 hours of storage. (Reservoir Capacity / Net Generating Capacity ≤ 24 hours).
b) Reservoir: This category contains hydro plants that have reservoirs, but do not have pumping capacity. They are pure generation plants with reservoirs with a storage capacity higher than 24 hours. (Reservoir Capacity / Net Generating
Capacity > 24 hours).
c) Open-loop Pump Storage: This category contains hydro plants that have Pumping capacity/technology in place, irrespectively of reservoir size, and that have Natural Inflows.
d) Closed-loop Pump Storage: This category contains hydro plants that have Pumping capacity/technology in place, irrespectively of reservoir size, and that do not have Natural Inflows.
Source: ENTSO-E; Hydropower modelling – New database complementing PECD. V.1.0, 12 September 2019, page 6.
With respect to the ENTSO-E def, we could extend the def of run of river:
_A run of river power plant is a hydro power plant that uses the momentarily available hydro energy of a river. It has either no reservoir or just has a small one with a maximum of 24 hours of storage._
It also gives good input for the pumped hydro storage power plant:
open-loop pumped hydro storage power plant: _An open-loop pumped hydro storage power plant is a pumped hydro storage power plant that has natural inflows._closed-loop pumped hydro storage power plant: _A closed-loop pumped hydro storage power plant is a pumped hydro storage power plant that has no natural inflows._Do we want a class like reservoir hydro storage power plant as subclass of hydro storage power plant, that explicitly excludes a pump?
Definition of hydro energy: maybe put 'potential' before 'kinetic' in definition as potential energy has even in run-off river power plants more impact than kinetic energy
As far as I remember, we agreed on that already.
Definition of hydro energy: maybe put 'potential' before 'kinetic' in definition as potential energy has even in run-off river power plants more impact than kinetic energy
As far as I remember, we agreed on that already.
In the pad of oeo dev 17 we wrote:
water turbine: potential energy has more impact than kinetic energy -> maybe put 'potential' before 'kinetic' in definition
The word _maybe_ highlighted by me. But if we now have a consensus I am happy with changing the def.
The word maybe highlighted by me. But if we now have a consensus I am happy with changing the def.
Ok. At least I'm in favour for that change. Any objections by others @OpenEnergyPlatform/oeo-domain-expert-energy-modelling ?
For pump: We defined a turbine as: _A turbine is an energy converting device that converts energy from a moving fluid flow into rotational energy._ As a pump is an inverted turbine, we could define pump as: _A pump is an energy converting device that converts rotational energy into energy of a moving fluid._
For river I created a separate issue #760.
water turbine: potential energy has more impact than kinetic energy -> maybe put 'potential' before 'kinetic' in definition
The word maybe highlighted by me. But if we now have a consensus I am happy with changing the def.
Ok. At least I'm in favour for that change. Any objections by others @OpenEnergyPlatform/oeo-domain-expert-energy-modelling ?
No objections for a week, so I will implement this.
I also added to the following editor note: _The distinction between a run of river powerplant and an hydro storage powerplant is important for modelling, but in reality not so easy. The chosen distinction follows the document: European Network of Transmission System Operators for Electricity (ENTSO-E): Hydropower modelling – New database complementing PECD, V.1.0, 12 December 2019, https://www.entsoe.eu/Documents/SDC%20documents/MAF/2019/Hydropower_Modelling_New_database_and_methodology.pdf_
For ocean energy and related terms I will create a separate issue.
So last remaining question in this issue:
Do we want a class like
reservoir hydro storage power plantas subclass ofhydro storage power plant, that explicitly excludes a pump?
As a pump is an inverted turbine, we could define pump as: _A pump is an energy converting device that converts rotational energy into energy of a moving fluid._
There're also other kinds of pumps. It's not necessarily rotational energy and for compressible fluids, e.g. air, a pump can also convert into potential energy.
What about: _A pump is an energy converting device that converts rotational energy into kinetic energy and potential energy of a fluid._?
Btw, we do not yet have fluid, but should define it. I'll create an issue for that.
_A pump is an energy converting device that converts energy into kinetic or potential energy of a fluid._?
Sounds good, I'll implement this new pump definition.
Do we want a class like
reservoir hydro storage power plantas subclass ofhydro storage power plant, that explicitly excludes a pump?
I created a separate issue for that #767 as this issue and pull request #758 already cover a lot of things.